[6.1][stdlib] Fix recoverable [U]Int128 division-by-zero #78045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch fixes the division-by-zero case in the following methods: - `Int128/dividedReportingOverflow(by:)` - `Int128/remainderReportingOverflow(dividingBy:)` - `UInt128/dividedReportingOverflow(by:)` - `UInt128/remainderReportingOverflow(dividingBy:)`
Jumping on the `_slowPath(_:)` bandwagon like all other integer types.
I have paraphrased @stephentyrone's and @xwu's review comments to the best of my ability.
|
@swift-ci test |
stephentyrone
approved these changes
Dec 8, 2024
|
Thanks @oscbyspro! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Int128andUInt128division by zero did not behave like smaller binary integer division by zero. This contribution updates the various division operations accordingly. It adds a missing precondition in signed%(_:_:)and replaces the preconditions in*ReportingOverflowwith recoverable results consistent with documented behavior.