Fix assertion failure when performing constant-evaluation through basic blocks with non-constant arguments #80873
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ic blocks with non-constant arguments
|
@swift-ci please test |
|
@swift-ci please test macOS platform |
|
@swift-ci please test Linux platform |
ravikandhadai
approved these changes
Apr 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes one of the issues exposed by #79707, which marked more integer initializers as
@_transparent.The constant evaluator was overly conservative in returning early when arguments to basic blocks were non-constant. This caused us to hit an assertion assuming that we would only fail to proceed past an unconditional branch if we are inside a loop.
Now, when encountering an unconditional branch, we always proceed to the destination basic block even if some of the arguments are non-constant. This lets us get as far as we can go in constant evaluation and avoids the assertion.