Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swift6 prep #54

Merged
merged 5 commits into from
Mar 4, 2024
Merged

Swift6 prep #54

merged 5 commits into from
Mar 4, 2024

Conversation

heckj
Copy link
Member

@heckj heckj commented Mar 4, 2024

  • updated package to use Swift 5.8 minimum
  • annotated methods and access that work with CGColorSpace and CGColor with @mainactor to constrain them for concurrency
  • updated general format flow to Swift 5.8 patterns (swiftformat .)

@heckj heckj self-assigned this Mar 4, 2024
Copy link

codecov bot commented Mar 4, 2024

Codecov Report

Attention: Patch coverage is 78.70968% with 33 lines in your changes are missing coverage. Please review.

Project coverage is 90.45%. Comparing base (ae61e35) to head (7f88458).

Files Patch % Lines
Sources/SwiftVizScale/ContinuousScale.swift 66.66% 11 Missing ⚠️
Sources/SwiftVizScale/SequentialScale.swift 0.00% 4 Missing ⚠️
Sources/SwiftVizScale/Color/LCH.swift 40.00% 3 Missing ⚠️
Sources/SwiftVizScale/DomainDataTransform.swift 0.00% 3 Missing ⚠️
...zScale/Interpolators/ComputedRGBInterpolator.swift 0.00% 3 Missing ⚠️
Sources/SwiftVizScale/ContinuousScaleType.swift 80.00% 2 Missing ⚠️
Sources/SwiftVizScale/DiscreteScale.swift 0.00% 2 Missing ⚠️
Sources/SwiftVizScale/BandScale.swift 92.30% 1 Missing ⚠️
Sources/SwiftVizScale/Histogram/Histogram.swift 94.44% 1 Missing ⚠️
...Scale/Interpolators/IndexedColorInterpolator.swift 75.00% 1 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #54      +/-   ##
==========================================
+ Coverage   90.41%   90.45%   +0.03%     
==========================================
  Files          40       40              
  Lines        3653     3634      -19     
==========================================
- Hits         3303     3287      -16     
+ Misses        350      347       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@heckj heckj merged commit 30fb385 into main Mar 4, 2024
4 of 5 checks passed
@heckj heckj deleted the swift6prep branch March 4, 2024 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant