-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sever client networking cryptographic provider initialisation #670
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #670 +/- ##
==========================================
- Coverage 51.23% 51.11% -0.12%
==========================================
Files 342 343 +1
Lines 29584 29520 -64
==========================================
- Hits 15156 15088 -68
- Misses 14428 14432 +4 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be better to allow the user to specify the default CryptoProvider
rather than adding it to the configuration. As we're providing a library, the Swim server could form part of a larger application where the user is relying on setting the default crypto provider an they want it used everywhere.
We should then either add a builder method to the server, or a feature flag to the crate (probably enabled by default) that will set the CryptoProvider
to our choice that can be used by people who don't want to care about it.
…r instead of panic
…t_crypto_provider # Conflicts: # server/swimos_server_app/Cargo.toml # swimos/Cargo.toml
No description provided.