Skip to content

Commit

Permalink
Merge branch 'main' into tokens/v2-24-10
Browse files Browse the repository at this point in the history
  • Loading branch information
alizedebray committed Oct 18, 2024
2 parents 19190b5 + c5d0423 commit b982012
Show file tree
Hide file tree
Showing 22 changed files with 668 additions and 429 deletions.
6 changes: 6 additions & 0 deletions .changeset/2024-10-17-update-icons.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
'@swisspost/design-system-icons': minor
---

Added icons number 2613, 2614, 2615, 2616, 2617, 2618, 2619 and 2620.

5 changes: 5 additions & 0 deletions .changeset/shiny-ears-care.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@swisspost/design-system-styles': patch
---

Updated margin styles according to the contribution guidelines. Content elements like headings and paragraphs no longer have a margin top if they're the first child and no margin bottom if they're the last child in a container.
7 changes: 7 additions & 0 deletions .changeset/tiny-socks-count.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
'@swisspost/design-system-components': patch
'@swisspost/design-system-components-angular': patch
'@swisspost/design-system-components-react': patch
---

Fixed an issue with property validation where some checks were run before the framework had the chance to add computed properties (for example Angular bindings like `[for]="$id"`). The checks are now delayed to work around this issue.
4 changes: 2 additions & 2 deletions .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -9,5 +9,5 @@
* @swisspost/design-system-maintainers

# Specific ownership for certain folders/files
/packages/documentation @swisspost/design-system-members
/packages/tokens/tokensstudio-generated/tokens.json @swisspost/design-system-members
/packages/documentation @swisspost/design-system-members @swisspost/design-system-maintainers
/packages/tokens/tokensstudio-generated/tokens.json @swisspost/design-system-members @swisspost/design-system-maintainers
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ export class PostAccordionItem {
);
}

connectedCallback() {
componentDidLoad() {
this.validateHeadingLevel();
}

Expand All @@ -51,7 +51,10 @@ export class PostAccordionItem {
// capture to make sure the "collapsed" property is updated before the event is consumed
@Listen('postToggle', { capture: true })
onCollapseToggle(event: CustomEvent<boolean>): void {
if (event.target === this.host && (event.target as HTMLElement).localName === 'post-accordion-item') {
if (
event.target === this.host &&
(event.target as HTMLElement).localName === 'post-accordion-item'
) {
this.collapsed = !event.detail;
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ export class PostAlert {
*/
@Event() postDismissed: EventEmitter<void>;

connectedCallback() {
componentDidLoad() {
this.validateDismissible();
this.validateFixed();
this.validateIcon();
Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/components/post-icon/post-icon.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ export class PostIcon {
checkEmptyOrType(newValue, 'number', 'The post-icon "scale" prop should be a number.');
}

componentWillLoad() {
componentDidLoad() {
this.validateBase();
this.validateName();
this.validateFlipH();
Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/components/post-logo/post-logo.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ export class PostLogo {
checkEmptyOrUrl(this.url, 'The "url" property of the post-logo is invalid');
}

connectedCallback() {
componentDidLoad() {
this.validateUrl();
this.checkDescription();
}
Expand Down
3 changes: 3 additions & 0 deletions packages/icons/public/post-icons/2613.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 3 additions & 0 deletions packages/icons/public/post-icons/2614.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 3 additions & 0 deletions packages/icons/public/post-icons/2615.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 3 additions & 0 deletions packages/icons/public/post-icons/2616.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 3 additions & 0 deletions packages/icons/public/post-icons/2617.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 3 additions & 0 deletions packages/icons/public/post-icons/2618.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 3 additions & 0 deletions packages/icons/public/post-icons/2619.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 3 additions & 0 deletions packages/icons/public/post-icons/2620.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading

0 comments on commit b982012

Please sign in to comment.