Skip to content

Commit

Permalink
chore(contributing): Precise HCM theme and add id-UUID (#2662)
Browse files Browse the repository at this point in the history
  • Loading branch information
imagoiq authored Feb 19, 2024
1 parent cab31bb commit d93c090
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ Use these commands whenever you want to work on one of these packages. Ideally,
#### Testing

- Cross browser testing of the docs (official Post supported browsers -> https://github.com/swisspost/design-system/blob/main/packages/styles/.browserslistrc)
- Testing the High Contrast mode
- Testing the High Contrast mode with light and dark theme (and cross browser)
- Approval by UX for the story
- Screen reader testing (at least nvda+win)

Expand All @@ -71,6 +71,7 @@ Use these commands whenever you want to work on one of these packages. Ideally,

#### Docs

- Add the `id` property in the meta of each story file. The property should contain an UUID (feel free to use your favorite tool)
- No react related attributes in code snippets (e.g. className, htmlFor, key, etc.)
- No nested `<p>` tags (beware of .lead and .alert)
- When using LinkTo use both the `kind` and `story` attributes
Expand Down

0 comments on commit d93c090

Please sign in to comment.