-
Notifications
You must be signed in to change notification settings - Fork 14
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(styles): Checked radio buttons is wrong on dark background (#2065)
## What This PR is a bit confusing as it addresses two problems. 1. Checked radio button were creating a visual shift in inline layout. It was fixed with #2086 by using a border instead of a margin. But it created the second following problem. 2. Checked radio button on dark background blends the circle indicator with the background. #2170 Other additions: - Added inline layout to snapshot ## UI ### Before ![image](https://github.com/swisspost/design-system/assets/12294151/a4f5b593-51b3-49aa-bbbb-cb73e39b7bae) ![image](https://github.com/swisspost/design-system/assets/12294151/1c8c2a1b-eab9-418b-ba4c-f2dff51668fa) ### After ![image](https://github.com/swisspost/design-system/assets/12294151/e2d8551b-7d5d-4474-a731-9e24f542a4f5) ![image](https://github.com/swisspost/design-system/assets/12294151/52a80a1d-ceef-4b07-b053-4d59a4aa35f2) --------- Co-authored-by: Philipp Gfeller <[email protected]>
- Loading branch information
Showing
4 changed files
with
15 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
'@swisspost/design-system-styles': patch | ||
--- | ||
|
||
Fixed offset of radio button when checked and in inline layout. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters