Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(components): add alert component #1085
feat(components): add alert component #1085
Changes from 20 commits
7044f83
b79b33f
07160b1
187459f
f89d587
a360e1e
d0e4a3b
13a13ec
cf26081
6fe2cdb
7b742c6
3bcdd59
afe108b
c1d63e5
7c7e4be
0be415e
5a7a161
f4615c0
4513ea4
c0efa28
1f8299a
346f33b
8282d83
1019295
def8fd1
06f45b1
bc27af3
6d15b46
0a97860
02cd74b
782fbc1
c079ddb
59b92cf
227a511
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't is covered by another rule, the fact that web components should be named with a dash? At least the browser throw a DOMexception error with invalid name: https://webcomponents.guide/learn/components/naming-your-components/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, but if you write
postalert
there is no error.