chore(styles, docs): re-apply mask icon changes #1945
Conversation
Apply mask icon changes to form validation Fix stories Add changesets
alizedebray
requested review from
b1aserlu and
davidritter-dotcom
as code owners
🦋 Changeset detectedLatest commit: 5eda2eb The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Preview environment ready: https://preview-1945--swisspost-web-frontend.netlify.app |
There was a problem hiding this comment.
There are lot of changes, which do not directly have a relation to the re-apply mask icon changes in my opinion.
For example the form-feedback/form-validation renaming.
It would be nice if we could split this PR up in smaller ones, so it's easier to review and we can add suitable changesets.
packages/documentation/src/stories/components/alert/alert.stories.ts
Outdated
Show resolved
Hide resolved
packages/documentation/src/stories/components/card/card.stories.ts
Outdated
Show resolved
Hide resolved
| @@ -45,4 +45,4 @@ | |||
| @use 'datepicker'; | |||
| @use 'dropdown'; | |||
| @use 'floating-label'; | |||
| @use 'form-feedback'; | |||
| @use 'form-validation'; | |||
There was a problem hiding this comment.
Is this part of this PR or should we move it to an own PR?
| background-position: center center; | ||
| &.datatable-icon-up, | ||
| &.datatable-icon-down { | ||
| @include icons-mx.icon(2112); |
There was a problem hiding this comment.
What do you think, should we document this mixin on the icons docs page?
There was a problem hiding this comment.
I don't think this mixin should be used externally.
We use it internally because styles need to display icons without being able to modify the HTML structure, but this is not the case for Design System users who need to use the post-icon component.
@oliverschuerch The goal of this PR is to merge back changes that were reverted a few weeks back and are now contained on this branch main...re-applied-icon-changes. There were several PRs originally which explains why the changes are disparate. The rollback was only due to issues found on the form check styles, so we decided during a Roundtable to address them in a separate ticket (#1953) and re-apply all other changes in a single PR (this one). |
…post/design-system into 1944-re-apply-icon-changes
|
Kudos, SonarCloud Quality Gate passed!
|
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @swisspost/[email protected] ### Minor Changes - Added the `post-tooltip` component. (by [@gfellerph](https://github.com/gfellerph) with [#1879](#1879)) - Created the web component variant for the alert component. (by [@alizedebray](https://github.com/alizedebray) with [#1085](#1085)) ### Patch Changes - Updated dependencies: - @swisspost/[email protected] ## @swisspost/[email protected] ### Minor Changes - Enabled nesting the header in a different scroll container than the `<body>` element. The header stickyness and logo animation logic will automatically attach to the nearest scrolling container instead of the document when nested in a container that has `overflow: auto | scroll` set. (by [@alizedebray](https://github.com/alizedebray) with [#1855](#1855)) - Added ability to toggle programmatically an overlay associated with a button using the `toggleOverlayById` method. (by [@imagoiq](https://github.com/imagoiq) with [#1838](#1838)) ### Patch Changes - Fixed an issue with custom configuration that was not applied when the prop "language" was not set on the internet header. (by [@alizedebray](https://github.com/alizedebray) with [#1855](#1855)) - Updated dependencies: - @swisspost/[email protected] ## @swisspost/[email protected] ### Patch Changes - Removed bound between logo and language to allow any language to display the logo. (by [@imagoiq](https://github.com/imagoiq) with [#2009](#2009)) - Updated dependencies: - @swisspost/[email protected] ## @swisspost/[email protected] ### Patch Changes - Removed bound between logo and language to allow any language to display the logo. (by [@imagoiq](https://github.com/imagoiq) with [#2009](#2009)) - Reduced the gap between the alert body and action buttons. (by [@alizedebray](https://github.com/alizedebray) with [#1085](#1085)) - Removed duplicated close button on toast when using ngx-toastr programatically. (by [@imagoiq](https://github.com/imagoiq) with [#2011](#2011)) - Updated and added the gaps between the title and the link-list in the `.topic-teaser-content` class to comply with the figma design. (by [@b1aserlu](https://github.com/b1aserlu) with [#1927](#1927)) - Added missing pointer-events to allow a dismissible toast to be closed interactively. (by [@imagoiq](https://github.com/imagoiq) with [#2008](#2008)) - Updated icons to display as mask images, this way their color can be set by adjusting the CSS `background-color` property. (by [@alizedebray](https://github.com/alizedebray) with [#1945](#1945)) ## @swisspost/[email protected] ### Minor Changes - Added the `post-tooltip` component. (by [@gfellerph](https://github.com/gfellerph) with [#1879](#1879)) - Integrated the google tag manager and the basic events (page_context, page_change) to the documentation. (by [@oliverschuerch](https://github.com/oliverschuerch) with [#1951](#1951)) - Created the web component variant for the alert component. (by [@alizedebray](https://github.com/alizedebray) with [#1085](#1085)) ### Patch Changes - Used the post-icon component instead of `.pi` classes to display icons in stories. (by [@alizedebray](https://github.com/alizedebray) with [#1945](#1945)) - Added deprecation alerts for `.form-control-rg`, `.form-control-md`, `.form-select-rg` and `.form-select-md` form-control variants. (by [@b1aserlu](https://github.com/b1aserlu) with [#1882](#1882)) - Updated dependencies: - @swisspost/[email protected] - @swisspost/[email protected] - @swisspost/[email protected] - @swisspost/[email protected] ## @swisspost/[email protected] ### Patch Changes - Updated dependencies: - @swisspost/[email protected] ## @swisspost/[email protected] ### Patch Changes - Updated dependencies: - @swisspost/[email protected] ## @swisspost/[email protected] ### Patch Changes - Updated the installation intructions for the Intranet Header. (by [@alizedebray](https://github.com/alizedebray) with [#1942](#1942)) - Added deprecation alerts for `.form-control-rg`, `.form-control-md`, `.form-select-rg` and `.form-select-md` form-control variants. (by [@b1aserlu](https://github.com/b1aserlu) with [#1882](#1882)) - Fixed ngBootstrap documentation links. (by [@imagoiq](https://github.com/imagoiq) with [#1987](#1987)) - Updated dependencies: - @swisspost/[email protected] - @swisspost/[email protected]
Used mask-image icons for all components except form checks that will be handled separately.