Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(documentation): add story to document spacing #1988

Merged
merged 15 commits into from
Oct 24, 2023

Conversation

davidritter-dotcom
Copy link
Contributor

Negativ margin is at the moment not documentetd, because the enable-negative-margins variable would need to be added to the _features.scss for the negativ margin classes of bootstrap to work and since we do not generate negativ margin utiliti classes for the post sizes it is not possible to use the negativ margin classes at the moment.

@davidritter-dotcom davidritter-dotcom requested review from b1aserlu and a team as code owners September 21, 2023 13:54
@davidritter-dotcom davidritter-dotcom linked an issue Sep 21, 2023 that may be closed by this pull request
@changeset-bot
Copy link

changeset-bot bot commented Sep 21, 2023

🦋 Changeset detected

Latest commit: 4bb4b05

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@swisspost/design-system-documentation Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@swisspost-bot
Copy link
Contributor

swisspost-bot commented Sep 21, 2023

Preview environment ready: https://preview-1988--swisspost-design-system-next.netlify.app

Copy link
Contributor

@oliverschuerch oliverschuerch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a changeset!

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@oliverschuerch oliverschuerch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice Work, Thank you @davidritter-dotcom!

@davidritter-dotcom davidritter-dotcom merged commit defcef2 into main Oct 24, 2023
@davidritter-dotcom davidritter-dotcom deleted the 541-story-spacing branch October 24, 2023 07:57
gfellerph pushed a commit that referenced this pull request Oct 24, 2023
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @swisspost/[email protected]

### Minor Changes

- Added a new button to clear the text in the search box. (by
[@b1aserlu](https://github.com/b1aserlu) with
[#2036](#2036))

### Patch Changes

- Added hide-buttons prop to hide all breadcrumbs buttons. (by
[@imagoiq](https://github.com/imagoiq) with
[#2027](#2027))

- Fixed internet-header search focus truncated on focus-within. (by
[@imagoiq](https://github.com/imagoiq) with
[#2043](#2043))

- Compressed styles output. (by [@imagoiq](https://github.com/imagoiq)
with [#2098](#2098))

-   Updated dependencies:
    -   @swisspost/[email protected]

## @swisspost/[email protected]

### Patch Changes

- Fixed misplaced custom icons in “post-alert” elements with actions.
(by [@alizedebray](https://github.com/alizedebray) with
[#2094](#2094))

- Updated the keyboard navigation on the `post-tabs` component. (by
[@alizedebray](https://github.com/alizedebray) with
[#2093](#2093))

- Fixed tabs count announcement with VoiceOver. (by
[@imagoiq](https://github.com/imagoiq) with
[#2047](#2047))

- Compressed styles output. (by [@imagoiq](https://github.com/imagoiq)
with [#2098](#2098))

-   Updated dependencies:
    -   @swisspost/[email protected]

## @swisspost/[email protected]

### Patch Changes

- Changed the main title of the intranet-header from `<h2>` to `<h1>`.
(by [@b1aserlu](https://github.com/b1aserlu) with
[#2104](#2104))
-   Updated dependencies:
    -   @swisspost/[email protected]

## @swisspost/[email protected]

### Patch Changes

- Refactored the grid-system: adjusted container paddings, added
responsive gutter-widths. Updated grid docs. (by
[@oliverschuerch](https://github.com/oliverschuerch) with
[#2045](#2045))

- Added small variants for checkbox and radio buttons. Lowered font-size
of validation blocks for form elements. (by
[@imagoiq](https://github.com/imagoiq) with
[#2086](#2086))

- Fixed missing active tab border on HTML component. (by
[@imagoiq](https://github.com/imagoiq) with
[#2037](#2037))

- Fixed active switch control showing a check icon in Chrome. (by
[@alizedebray](https://github.com/alizedebray) with
[#2090](#2090))

## @swisspost/[email protected]

### Minor Changes

- Added a docs page for our spacing utilities (by
[@davidritter-dotcom](https://github.com/davidritter-dotcom) with
[#1988](#1988))

- Added a docs page for our grid-system. (by
[@oliverschuerch](https://github.com/oliverschuerch) with
[#1947](#1947))

### Patch Changes

- Refactored the grid-system: adjusted container paddings, added
responsive gutter-widths. Updated grid docs. (by
[@oliverschuerch](https://github.com/oliverschuerch) with
[#2045](#2045))

- Fixed the "fixed" control in the `post-alert` documentation. (by
[@alizedebray](https://github.com/alizedebray) with
[#2094](#2094))

-   Updated dependencies:
    -   @swisspost/[email protected]
    -   @swisspost/[email protected]
    -   @swisspost/[email protected]
    -   @swisspost/[email protected]

## @swisspost/[email protected]

### Patch Changes

-   Updated dependencies:
    -   @swisspost/[email protected]

## @swisspost/[email protected]

### Patch Changes

-   Updated dependencies:
    -   @swisspost/[email protected]

## @swisspost/[email protected]

### Patch Changes

-   Updated dependencies:
    -   @swisspost/[email protected]
    -   @swisspost/[email protected]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Story: Spacing
4 participants