Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(documentation): header image color rendering on Firefox #1994

Merged
merged 1 commit into from
Sep 26, 2023
Merged

fix(documentation): header image color rendering on Firefox #1994

merged 1 commit into from
Sep 26, 2023

Conversation

imagoiq
Copy link
Contributor

@imagoiq imagoiq commented Sep 26, 2023

Before

zxwbX5WO6X

After

8z8aXwiwzG

@imagoiq imagoiq requested a review from b1aserlu as a code owner September 26, 2023 06:23
@imagoiq imagoiq self-assigned this Sep 26, 2023
@imagoiq imagoiq requested review from davidritter-dotcom and a team as code owners September 26, 2023 06:23
@changeset-bot
Copy link

changeset-bot bot commented Sep 26, 2023

⚠️ No Changeset found

Latest commit: 4f61919

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

imagoiq
imagoiq commented Sep 26, 2023
View reviewed changes
packages/internet-header/src/components/post-internet-header/readme.md
| `languageSwitchOverrides` | `language-switch-overrides` | Override the language switch links with custom URLs. Helpful when your application contains sub-pages and you would like to stay on subpages when the user changes language. | `IAvailableLanguage[] \| string \| undefined` | `undefined` |
| `languageSwitchOverrides` | `language-switch-overrides` | Override the language switch links with custom URLs. Helpful when your application contains sub-pages, and you would like to stay on subpages when the user changes language. | `IAvailableLanguage[] \| string \| undefined` | `undefined` |
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an uncommitted change from a PR that has been merged on main (not sure which one), but it appears everywhere, so let's fix it.

@swisspost-bot
Copy link
Contributor

swisspost-bot commented Sep 26, 2023 •
edited
Loading

Preview environment ready: https://preview-1994--swisspost-design-system-next.netlify.app

@imagoiq imagoiq merged commit 7d8038c into main Sep 26, 2023
@imagoiq imagoiq deleted the fix/header-image-color-rendering branch September 26, 2023 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@b1aserlu b1aserlu Awaiting requested review from b1aserlu

@davidritter-dotcom davidritter-dotcom Awaiting requested review from davidritter-dotcom

Assignees

@imagoiq imagoiq

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@imagoiq @swisspost-bot