Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(intranet-header): Implement Intranet-Header language independent #2009

Merged
merged 4 commits into from
Oct 2, 2023

Conversation

imagoiq
Copy link
Contributor

@imagoiq imagoiq commented Sep 27, 2023

No description provided.

@imagoiq imagoiq self-assigned this Sep 27, 2023
@changeset-bot
Copy link

changeset-bot bot commented Sep 27, 2023

🦋 Changeset detected

Latest commit: 8eaba4b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
@swisspost/design-system-intranet-header Patch
@swisspost/design-system-styles Patch
@swisspost/design-system-demo Patch
@swisspost/design-system-components-angular Patch
@swisspost/design-system-components Patch
@swisspost/design-system-documentation Patch
@swisspost/internet-header Patch
@swisspost/design-system-components-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@imagoiq imagoiq linked an issue Sep 27, 2023 that may be closed by this pull request
@swisspost-bot
Copy link
Contributor

swisspost-bot commented Sep 27, 2023

Preview environment ready: https://preview-2009--swisspost-web-frontend.netlify.app
Preview environment ready: https://preview-2009--swisspost-design-system-next.netlify.app

Comment on lines -24 to +31
<a href="#installation" target="_self">
Installation
</a>
<a href="#installation" target="_self">Installation</a>
</li>
<li>
<a href="#usage" target="_self">
Usage
</a>
<a href="#usage" target="_self">Usage</a>
</li>
<li>
<a href="#examples" target="_self">
Examples
</a>
<a href="#examples" target="_self">Examples</a>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are empty lines inside li

@imagoiq imagoiq force-pushed the 1949-intranet-header-logo-language branch from 01b009e to c0ebe06 Compare September 28, 2023 15:31
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@imagoiq imagoiq merged commit 75c847b into main Oct 2, 2023
10 checks passed
@imagoiq imagoiq deleted the 1949-intranet-header-logo-language branch October 2, 2023 13:09
gfellerph pushed a commit that referenced this pull request Oct 4, 2023
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @swisspost/[email protected]

### Minor Changes

- Added the `post-tooltip` component. (by
[@gfellerph](https://github.com/gfellerph) with
[#1879](#1879))

- Created the web component variant for the alert component. (by
[@alizedebray](https://github.com/alizedebray) with
[#1085](#1085))

### Patch Changes

-   Updated dependencies:
    -   @swisspost/[email protected]

## @swisspost/[email protected]

### Minor Changes

- Enabled nesting the header in a different scroll container than the
`<body>` element. The header stickyness and logo animation logic will
automatically attach to the nearest scrolling container instead of the
document when nested in a container that has `overflow: auto | scroll`
set. (by [@alizedebray](https://github.com/alizedebray) with
[#1855](#1855))

- Added ability to toggle programmatically an overlay associated with a
button using the `toggleOverlayById` method. (by
[@imagoiq](https://github.com/imagoiq) with
[#1838](#1838))

### Patch Changes

- Fixed an issue with custom configuration that was not applied when the
prop "language" was not set on the internet header. (by
[@alizedebray](https://github.com/alizedebray) with
[#1855](#1855))
-   Updated dependencies:
    -   @swisspost/[email protected]

## @swisspost/[email protected]

### Patch Changes

- Removed bound between logo and language to allow any language to
display the logo. (by [@imagoiq](https://github.com/imagoiq) with
[#2009](#2009))
-   Updated dependencies:
    -   @swisspost/[email protected]

## @swisspost/[email protected]

### Patch Changes

- Removed bound between logo and language to allow any language to
display the logo. (by [@imagoiq](https://github.com/imagoiq) with
[#2009](#2009))

- Reduced the gap between the alert body and action buttons. (by
[@alizedebray](https://github.com/alizedebray) with
[#1085](#1085))

- Removed duplicated close button on toast when using ngx-toastr
programatically. (by [@imagoiq](https://github.com/imagoiq) with
[#2011](#2011))

- Updated and added the gaps between the title and the link-list in the
`.topic-teaser-content` class to comply with the figma design. (by
[@b1aserlu](https://github.com/b1aserlu) with
[#1927](#1927))

- Added missing pointer-events to allow a dismissible toast to be closed
interactively. (by [@imagoiq](https://github.com/imagoiq) with
[#2008](#2008))

- Updated icons to display as mask images, this way their color can be
set by adjusting the CSS `background-color` property. (by
[@alizedebray](https://github.com/alizedebray) with
[#1945](#1945))

## @swisspost/[email protected]

### Minor Changes

- Added the `post-tooltip` component. (by
[@gfellerph](https://github.com/gfellerph) with
[#1879](#1879))

- Integrated the google tag manager and the basic events (page_context,
page_change) to the documentation. (by
[@oliverschuerch](https://github.com/oliverschuerch) with
[#1951](#1951))

- Created the web component variant for the alert component. (by
[@alizedebray](https://github.com/alizedebray) with
[#1085](#1085))

### Patch Changes

- Used the post-icon component instead of `.pi` classes to display icons
in stories. (by [@alizedebray](https://github.com/alizedebray) with
[#1945](#1945))

- Added deprecation alerts for `.form-control-rg`, `.form-control-md`,
`.form-select-rg` and `.form-select-md` form-control variants. (by
[@b1aserlu](https://github.com/b1aserlu) with
[#1882](#1882))

-   Updated dependencies:
    -   @swisspost/[email protected]
    -   @swisspost/[email protected]
    -   @swisspost/[email protected]
    -   @swisspost/[email protected]

## @swisspost/[email protected]

### Patch Changes

-   Updated dependencies:
    -   @swisspost/[email protected]

## @swisspost/[email protected]

### Patch Changes

-   Updated dependencies:
    -   @swisspost/[email protected]

## @swisspost/[email protected]

### Patch Changes

- Updated the installation intructions for the Intranet Header. (by
[@alizedebray](https://github.com/alizedebray) with
[#1942](#1942))

- Added deprecation alerts for `.form-control-rg`, `.form-control-md`,
`.form-select-rg` and `.form-select-md` form-control variants. (by
[@b1aserlu](https://github.com/b1aserlu) with
[#1882](#1882))

- Fixed ngBootstrap documentation links. (by
[@imagoiq](https://github.com/imagoiq) with
[#1987](#1987))

-   Updated dependencies:
    -   @swisspost/[email protected]
    -   @swisspost/[email protected]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Intranet-Header language independent
3 participants