Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(styles): update dependencies and fix some things #2150

Merged
merged 10 commits into from
Nov 1, 2023

Conversation

gfellerph
Copy link
Member

This PR is a little more that dependency updates:

  • Updates all possible dependencies of the styles package
  • Fixes new linting errors after the update
  • Fixes unit tests not running on the styles package
  • Fixes an issue with prettier after the update in the migrations

@gfellerph gfellerph requested a review from a team as a code owner October 27, 2023 12:26
@gfellerph gfellerph requested a review from imagoiq October 27, 2023 12:26
@changeset-bot
Copy link

changeset-bot bot commented Oct 27, 2023

⚠️ No Changeset found

Latest commit: 20db46e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@swisspost-bot
Copy link
Contributor

swisspost-bot commented Oct 27, 2023

Preview environment ready: https://preview-2150--swisspost-web-frontend.netlify.app
Preview environment ready: https://preview-2150--swisspost-design-system-next.netlify.app

Copy link
Contributor

@imagoiq imagoiq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great to first merge #2137 (and the base #2140) before as otherwise it will make potentially some merge issues.

@gfellerph gfellerph added the 🚂 PR train PR which follows another one. label Oct 30, 2023
Copy link

sonarqubecloud bot commented Nov 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@gfellerph gfellerph merged commit 4e7812d into main Nov 1, 2023
10 checks passed
@gfellerph gfellerph deleted the update-styles-deps branch November 1, 2023 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚂 PR train PR which follows another one.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants