fix(documentation): edit on Github breaks page without stories attached #2267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imagoiq
requested review from
b1aserlu,
davidritter-dotcom and
a team
as code owners
🦋 Changeset detectedLatest commit: a991d2b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Preview environment ready: https://preview-2267--swisspost-design-system-next.netlify.app |
alizedebray
approved these changes
Nov 14, 2023
|
The changeset is missing |
|
Kudos, SonarCloud Quality Gate passed!
|
gfellerph
pushed a commit
that referenced
this pull request
Nov 23, 2023
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @swisspost/[email protected] ### Patch Changes - Updated icons number 2081, 2143, 2221, 2230, 2238, 2239, 2248, 2249, 2250, 2254, 2256, 2257, 2258, 2260, 2261, 2262, 2263, 2264, 2265, 2266, 2267, 2268, 2269, 2270, 2271, 2272, 2273, 2274, 2275, 2276, 2280, 2281, 2361, 2386, 2403, 2415, 2418, 2419, 2433, 2434, 2457, 2464 and 2488. (by [@swisspost-bot](https://github.com/swisspost-bot) with [#2284](#2284)) ## @swisspost/[email protected] ### Minor Changes - Added link to new documentation (by [@davidritter-dotcom](https://github.com/davidritter-dotcom) with [#2142](#2142)) - Deprecated standard HTML alerts with a close button in favor of the `post-alert` component designed to correctly handle the dismissal animation. (by [@b1aserlu](https://github.com/b1aserlu) with [#2239](#2239)) ### Patch Changes - Updated dependencies: - @swisspost/[email protected] ## @swisspost/[email protected] ### Minor Changes - Added a documentation page for the `.container` and `.container-fluid` classes. (by [@b1aserlu](https://github.com/b1aserlu) with [#2030](#2030)) ### Patch Changes - Removed empty p and fix CDN examples for internet-header. (by [@imagoiq](https://github.com/imagoiq) with [#2295](#2295)) - Added attached stories to changelog and search-icons pages to fix "Edit this page on Github" feature. (by [@imagoiq](https://github.com/imagoiq) with [#2267](#2267)) - Updated dependencies: - @swisspost/[email protected] - @swisspost/[email protected] Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Changelog and search for icons page after #2132. If
storyIdToCSFFileis not defined for example on docs page without stories attached, it breaks the whole page.