Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(documentation): add placeholder to search for icons docs and document it #2268

Merged
merged 1 commit into from
Nov 20, 2023
Merged

fix(documentation): add placeholder to search for icons docs and document it #2268

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/documentation/src/stories/components/input/input.docs.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@ The following examples show the different characteristics of the component. Thes
Wrap a pair of `<input>` and `<label>` elements in a `.form-floating` container to enable floating labels.<br/>
But note that the `<input>` element must come first, so we can ensure the correct styles.

Ensure that `placeholder` attribute is set (even with an empty value) so the label can act as a placeholder when no value is set.

<Canvas of={InputStories.FloatingLabel} />

### Sizing
Expand Down
1 change: 1 addition & 0 deletions packages/documentation/src/stories/icons/search-icons/search-icons.blocks.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ export class Search extends React.Component {
id="IconSearchFilter_Freetext"
type="text"
className="form-control"
placeholder=""
value={this.state.freetext}
onChange={this.searchFreetext.bind(this)}
ref={this.freetextRef}
Expand Down