feat(styles): add custom theme for primeng #2718

alizedebray · 2024-02-22T10:55:51Z

No description provided.

changeset-bot · 2024-02-22T10:55:55Z

🦋 Changeset detected

Latest commit: e907059

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages

Name	Type
@swisspost/design-system-styles-primeng	Major
@swisspost/design-system-styles-primeng-workspace	Major
@swisspost/design-system-documentation	Minor
@swisspost/design-system-styles	Patch
@swisspost/design-system-components-angular-workspace	Patch
@swisspost/design-system-components	Patch
@swisspost/design-system-demo	Patch
@swisspost/internet-header	Patch
@swisspost/design-system-intranet-header-workspace	Patch
@swisspost/design-system-nextjs-integration	Patch
@swisspost/design-system-intranet-header	Patch
@swisspost/design-system-components-react	Patch
@swisspost/design-system-components-angular	Patch
@swisspost/design-system-intranet-header-showcase	Patch
@swisspost/design-system-icons	Patch
@swisspost/design-system-migrations	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

swisspost-bot · 2024-02-22T10:58:03Z

Preview environment ready: https://preview-2718--swisspost-web-frontend.netlify.app
Preview environment ready: https://preview-2718--swisspost-design-system-next.netlify.app

alizedebray · 2024-02-27T17:09:33Z

Quality Gate failed

Failed conditions D Reliability Rating on New Code (required ≥ A) 9 New Code Smells (required ≤ 0)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

9 issues come from primeng base theme, should we correct them or exclude the folder from sonar analysis?

The 18 others are to style icons targeting the component tag selector, we probably have to mark them as false positive.

alizedebray · 2024-02-27T17:11:54Z

...-primeng-workspace/projects/styles-primeng/src/lib/primeng-theme/bootstrap-theme/_index.scss

This variables directly come from the primeng bootstrap theme.

alizedebray · 2024-02-27T17:13:28Z

...yles-primeng-workspace/projects/styles-primeng/src/lib/primeng-theme/theme-base/_colors.scss

All the file in the theme-base directory directly come from the primeng base theme.

packages/styles-primeng-workspace/projects/styles-primeng-showcase/src/app/app.component.html

...-primeng-workspace/projects/styles-primeng/src/lib/primeng-theme/theme-base/_components.scss

imagoiq · 2024-02-28T08:47:08Z

Quality Gate failed

Failed conditions D Reliability Rating on New Code (required ≥ A) 9 New Code Smells (required ≤ 0)
See analysis details on SonarCloud
Catch issues before they fail your Quality Gate with our IDE extension SonarLint

9 issues come from primeng base theme, should we correct them or exclude the folder from sonar analysis?

The 18 others are to style icons targeting the component tag selector, we probably have to mark them as false positive.

As they are in the repo, I would have said correct them, but we also don't want that those files derive too much from the original as it's hard to see changes when upgrading.

alizedebray · 2024-03-05T14:41:10Z

Quality Gate failed

Failed conditions D Reliability Rating on New Code (required ≥ A) 9 New Code Smells (required ≤ 0)
See analysis details on SonarCloud
Catch issues before they fail your Quality Gate with our IDE extension SonarLint

9 issues come from primeng base theme, should we correct them or exclude the folder from sonar analysis?
The 18 others are to style icons targeting the component tag selector, we probably have to mark them as false positive.

As they are in the repo, I would have said correct them, but we also don't want that those files derive too much from the original as it's hard to see changes when upgrading.

I marked the icon errors as false positive in Sonar and fixed the other issues.

packages/styles-primeng-workspace/package.json

packages/styles-primeng-workspace/projects/styles-primeng/package.json

packages/styles-primeng-workspace/projects/styles-primeng/README.md

packages/styles-primeng-workspace/LICENSE

Co-authored-by: Philipp Gfeller <[email protected]>

…age.json Co-authored-by: Philipp Gfeller <[email protected]>

…ME.md Co-authored-by: Philipp Gfeller <[email protected]>

swisspost-bot · 2024-06-20T06:55:06Z

Related Previews

packages/styles-primeng-workspace/projects/styles-primeng/package.json

…age.json Co-authored-by: Philipp Gfeller <[email protected]>

sonarqubecloud · 2024-07-16T15:05:53Z

Quality Gate passed

Issues
0 New issues
8 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@davidritter-dotcom

This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @swisspost/[email protected] ### Minor Changes - Added an invalid message for the card-control component and an icon in the invalid message of the checkbox and radio button (by [@davidritter-dotcom](https://github.com/davidritter-dotcom) with [#2978](#2978)) - Added a `delayed` property to the `post-tooltip` component to allow delaying its display for a few milliseconds after it is triggered. (by [@alizedebray](https://github.com/alizedebray) with [#3245](#3245)) - Added a `post-collapsible-trigger` component to properly handle the role, ARIA attributes, and event listeners for elements that toggle a `post-collapsible`. (by [@alizedebray](https://github.com/alizedebray) with [#3209](#3209)) ### Patch Changes - Fixed an issue with popovers on Firefox ESR that unexpectedly closed popovers when clicking on content. (by [@gfellerph](https://github.com/gfellerph) with [#3211](#3211)) - Prevent the `post-tabs` component from triggering a `post Change` event before it is loaded. (by [@alizedebray](https://github.com/alizedebray) with [#3247](#3247)) - Updated dependencies: - @swisspost/[email protected] ## @swisspost/[email protected] ### Minor Changes - Added a `post-collapsible-trigger` component to properly handle the role, ARIA attributes, and event listeners for elements that toggle a `post-collapsible`. (by [@alizedebray](https://github.com/alizedebray) with [#3209](#3209)) ### Patch Changes - Updated dependencies: - @swisspost/[email protected] ## @swisspost/[email protected] ### Minor Changes - Added icons number 2592, 2593, 2594 and 2595. (by [@swisspost-bot](https://github.com/swisspost-bot) with [#3264](#3264)) ## @swisspost/[email protected] ### Minor Changes - Added a new stylesheet containing `:root` CSS custom properties to facilitate implementing styles relative to the header. This will allow putting sticky content right below the header. (by [@alizedebray](https://github.com/alizedebray) with [#3200](#3200)) ### Patch Changes - Updated dependencies: - @swisspost/[email protected] ## @swisspost/[email protected] ### Minor Changes - Added an invalid message for the card-control component and an icon in the invalid message of the checkbox and radio button (by [@davidritter-dotcom](https://github.com/davidritter-dotcom) with [#2978](#2978)) - Pre-compiled CSS files are now shipped with the package to enable projects not using Sass to selectively import component styles. (by [@gfellerph](https://github.com/gfellerph) with [#3283](#3283)) ### Patch Changes - Fixed visual issues with validated form-elements who receive focus. (by [@oliverschuerch](https://github.com/oliverschuerch) with [#3166](#3166)) - Updated buttons colors. (by [@imagoiq](https://github.com/imagoiq) with [#2977](#2977)) - Updated table colors on dark backgrounds. (by [@alizedebray](https://github.com/alizedebray) with [#2718](#2718)) - Switched from light to regular font weight for most texts, excluding sub-titles. (by [@oliverschuerch](https://github.com/oliverschuerch) with [#3284](#3284)) ## @swisspost/[email protected] ### Minor Changes - Created a Swiss Post Design System theme for PrimeNg datatable. (by [@alizedebray](https://github.com/alizedebray) with [#2718](#2718)) ### Patch Changes - Updated dependencies: - @swisspost/[email protected] ## @swisspost/[email protected] ### Patch Changes - Updated dependencies: - @swisspost/[email protected] ## @swisspost/[email protected] ## @swisspost/[email protected] ### Major Changes - Created a workspace to maintain the Swiss Post PrimeNg theme. (by [@alizedebray](https://github.com/alizedebray) with [#2718](#2718)) ### Patch Changes - Updated dependencies: - @swisspost/[email protected] ## @swisspost/[email protected] ### Minor Changes - Added a `post-collapsible-trigger` component to properly handle the role, ARIA attributes, and event listeners for elements that toggle a `post-collapsible`. (by [@alizedebray](https://github.com/alizedebray) with [#3209](#3209)) ### Patch Changes - Updated dependencies: - @swisspost/[email protected] ## @swisspost/[email protected] ### Minor Changes - Added a new stylesheet containing `:root` CSS custom properties to facilitate implementing styles relative to the header. This will allow putting sticky content right below the header. (by [@alizedebray](https://github.com/alizedebray) with [#3200](#3200)) - Added the compatibility table entries for v7. (by [@oliverschuerch](https://github.com/oliverschuerch) with [#3294](#3294)) - Added a `delayed` property to the `post-tooltip` component to allow delaying its display for a few milliseconds after it is triggered. (by [@alizedebray](https://github.com/alizedebray) with [#3245](#3245)) - Added documentation on how to get started with the `@swisspost/design-system-styles-primeng` package. (by [@alizedebray](https://github.com/alizedebray) with [#2718](#2718)) - Added a `post-collapsible-trigger` component to properly handle the role, ARIA attributes, and event listeners for elements that toggle a `post-collapsible`. (by [@alizedebray](https://github.com/alizedebray) with [#3209](#3209)) ### Patch Changes - Fixed the documentation heading links by adding the rehype-slug plugin (by [@davidritter-dotcom](https://github.com/davidritter-dotcom) with [#3279](#3279)) - Deprecated accent colors. (by [@davidritter-dotcom](https://github.com/davidritter-dotcom) with [#3195](#3195)) - Updated tabs to improve visual continuity and readability. (by [@alizedebray](https://github.com/alizedebray) with [#3254](#3254)) - Fixed the wrong implementation of the intranet-header changeset.md file in the changelog/intranet-header docs page. (by [@oliverschuerch](https://github.com/oliverschuerch) with [#3293](#3293)) - Fix headers for the `versions.json` file. So it can be loaded and used from the version-switcher of older documentation pages. (by [@oliverschuerch](https://github.com/oliverschuerch) with [#3267](#3267)) - Removed horizontal scrollbar showing up in Firefox, when a docs specific tab component is present on the page. (by [@oliverschuerch](https://github.com/oliverschuerch) with [#3268](#3268)) - Updated dependencies: - @swisspost/[email protected] - @swisspost/[email protected] - @swisspost/[email protected] - @swisspost/[email protected] - @swisspost/[email protected] ## @swisspost/[email protected] ### Patch Changes - Updated dependencies: - @swisspost/[email protected] - @swisspost/[email protected] ## @swisspost/[email protected] ### Patch Changes - Updated dependencies: - @swisspost/[email protected] - @swisspost/[email protected] - @swisspost/[email protected] ## @swisspost/[email protected] ### Patch Changes - Updated dependencies: - @swisspost/[email protected] ## @swisspost/[email protected] ### Patch Changes - Updated dependencies: - @swisspost/[email protected] ## @swisspost/[email protected] ### Patch Changes - Updated dependencies: - @swisspost/[email protected] - @swisspost/[email protected] - @swisspost/[email protected] --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

feat(styles): add custom theme for primeng

31b5727

alizedebray and others added 4 commits February 27, 2024 17:28

feat(styles): add custom theme for primeng

b5daec5

Add changeset for the docs

f61929b

Merge branch 'main' into 2069-styles-for-prime-ng-datatable

8b4355a

fix sonar issues

de4c920

alizedebray force-pushed the 2069-styles-for-prime-ng-datatable branch from 476e1dc to de4c920 Compare February 27, 2024 17:04

alizedebray marked this pull request as ready for review February 27, 2024 17:09

alizedebray requested a review from a team as a code owner February 27, 2024 17:09

alizedebray requested a review from imagoiq February 27, 2024 17:09

alizedebray commented Feb 27, 2024

View reviewed changes

alizedebray requested review from gfellerph and oliverschuerch February 27, 2024 17:14

Disable analytics

7fead56

imagoiq approved these changes Feb 28, 2024

View reviewed changes

packages/styles-primeng-workspace/projects/styles-primeng-showcase/src/app/app.component.html Outdated Show resolved Hide resolved

...-primeng-workspace/projects/styles-primeng/src/lib/primeng-theme/theme-base/_components.scss Show resolved Hide resolved

alizedebray added 4 commits March 5, 2024 11:37

fix sonar issues

8227dde

Merge branch 'main' into 2069-styles-for-prime-ng-datatable

c09f108

Update .stylelintrc

22e2172

Update _steps.scss

d6c03b4

alizedebray closed this Mar 5, 2024

alizedebray reopened this Mar 5, 2024

gfellerph requested changes Mar 7, 2024

View reviewed changes

alizedebray and others added 3 commits March 7, 2024 17:23

Update packages/styles-primeng-workspace/package.json

8a69d66

Co-authored-by: Philipp Gfeller <[email protected]>

Update packages/styles-primeng-workspace/projects/styles-primeng/pack…

5502d45

…age.json Co-authored-by: Philipp Gfeller <[email protected]>

Update packages/styles-primeng-workspace/projects/styles-primeng/READ…

1bf57e3

…ME.md Co-authored-by: Philipp Gfeller <[email protected]>

oliverschuerch removed their request for review April 26, 2024 06:13

Merge branch 'main' into 2069-styles-for-prime-ng-datatable

ee5bbfe

alizedebray linked an issue Apr 29, 2024 that may be closed by this pull request

Styles for prime ng datatable #2069

Closed

alizedebray force-pushed the 2069-styles-for-prime-ng-datatable branch from a930f79 to e61ba56 Compare April 29, 2024 15:55

Update angular version

32a9095

alizedebray force-pushed the 2069-styles-for-prime-ng-datatable branch from e61ba56 to 32a9095 Compare April 29, 2024 15:57

alizedebray added 3 commits April 29, 2024 18:21

Remove the need for a specific layer to use prime ng styles

c36d202

Delete CHANGELOG.md

4e4ea77

Fix code smells

ac2b5cf

This comment was marked as duplicate.

Sign in to view

alizedebray requested a review from gfellerph May 2, 2024 15:46

alizedebray added 2 commits June 20, 2024 08:48

Merge branch 'main' into 2069-styles-for-prime-ng-datatable

4863852

Update styles version

1879c03

alizedebray added 5 commits June 20, 2024 08:59

Fix linting issues

6a2fdc5

fix sonar issues

0a1b9c3

update showcase app

2c5c3fa

Fix paginator

e81db62

Add focus rings

afec923

gfellerph approved these changes Jul 16, 2024

View reviewed changes

packages/styles-primeng-workspace/projects/styles-primeng/package.json Outdated Show resolved Hide resolved

packages/styles-primeng-workspace/projects/styles-primeng/package.json Outdated Show resolved Hide resolved

alizedebray and others added 5 commits July 16, 2024 16:53

Update packages/styles-primeng-workspace/projects/styles-primeng/pack…

f9d9235

…age.json Co-authored-by: Philipp Gfeller <[email protected]>

Update packages/styles-primeng-workspace/projects/styles-primeng/pack…

de9f738

…age.json Co-authored-by: Philipp Gfeller <[email protected]>

Merge branch 'main' into 2069-styles-for-prime-ng-datatable

357bf5a

Update packages

ef30d29

Merge branch 'main' into 2069-styles-for-prime-ng-datatable

e907059

alizedebray merged commit 9a88173 into main Jul 18, 2024
10 checks passed

alizedebray deleted the 2069-styles-for-prime-ng-datatable branch July 18, 2024 06:27

swisspost-bot mentioned this pull request Jul 18, 2024

chore(changesets): 🦋📦 publish packages (main) #3234

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(styles): add custom theme for primeng #2718

feat(styles): add custom theme for primeng #2718

alizedebray commented Feb 22, 2024

changeset-bot bot commented Feb 22, 2024 •

edited

Loading

swisspost-bot commented Feb 22, 2024 •

edited

Loading

alizedebray commented Feb 27, 2024

Quality Gate failed

alizedebray Feb 27, 2024

alizedebray Feb 27, 2024

imagoiq commented Feb 28, 2024

Quality Gate failed

alizedebray commented Mar 5, 2024 •

edited

Loading

Quality Gate failed

This comment was marked as duplicate.

swisspost-bot commented Jun 20, 2024 •

edited

Loading

sonarqubecloud bot commented Jul 16, 2024

feat(styles): add custom theme for primeng #2718

feat(styles): add custom theme for primeng #2718

Conversation

alizedebray commented Feb 22, 2024

changeset-bot bot commented Feb 22, 2024 • edited Loading

🦋 Changeset detected

swisspost-bot commented Feb 22, 2024 • edited Loading

alizedebray commented Feb 27, 2024

Quality Gate failed

alizedebray Feb 27, 2024

Choose a reason for hiding this comment

alizedebray Feb 27, 2024

Choose a reason for hiding this comment

imagoiq commented Feb 28, 2024

Quality Gate failed

alizedebray commented Mar 5, 2024 • edited Loading

Quality Gate failed

This comment was marked as duplicate.

swisspost-bot commented Jun 20, 2024 • edited Loading

sonarqubecloud bot commented Jul 16, 2024

Quality Gate passed

changeset-bot bot commented Feb 22, 2024 •

edited

Loading

swisspost-bot commented Feb 22, 2024 •

edited

Loading

alizedebray commented Mar 5, 2024 •

edited

Loading

swisspost-bot commented Jun 20, 2024 •

edited

Loading