Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docs): update tag documentation page #2895

Merged
merged 13 commits into from
Apr 10, 2024
Merged

fix(docs): update tag documentation page #2895

merged 13 commits into from
Apr 10, 2024

Conversation

alizedebray
Copy link
Contributor

No description provided.

@alizedebray alizedebray requested a review from a team as a code owner April 8, 2024 15:28
@alizedebray alizedebray requested a review from imagoiq April 8, 2024 15:28
@alizedebray alizedebray linked an issue Apr 8, 2024 that may be closed by this pull request
Fix tag stories #2894
Closed
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 8, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 44dfc10

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@swisspost-bot
Copy link
Contributor

swisspost-bot commented Apr 8, 2024 •
edited
Loading

Preview environment ready: https://preview-2895--swisspost-web-frontend.netlify.app
Preview environment ready: https://preview-2895--swisspost-design-system-next.netlify.app

@gfellerph gfellerph added the v7 label Apr 9, 2024
@alizedebray alizedebray requested a review from gfellerph April 9, 2024 14:37
imagoiq
imagoiq approved these changes Apr 10, 2024
View reviewed changes
Copy link
Contributor

@imagoiq imagoiq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changesets are missing

packages/styles/src/variables/components/_tag.scss Outdated
@@ -16,9 +16,9 @@ $tag-icon-size: $tag-font-size * 1.25;
$tag-sm-line-height: spacing.$size-large;
$tag-sm-icon-size: $tag-font-size;

$tag-background: color.$gray-10;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
$tag-background: color.$gray-10;
$tag-default-background: color.$gray-10;

It would be nice to clarify the intent of this variable

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@alizedebray alizedebray merged commit 53b36d2 into main Apr 10, 2024
9 checks passed
@alizedebray alizedebray deleted the 2894-fix-tag-stories branch April 10, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imagoiq imagoiq imagoiq approved these changes

@gfellerph gfellerph Awaiting requested review from gfellerph

Assignees
No one assigned
Labels
v7
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix tag stories
4 participants
@alizedebray @swisspost-bot @imagoiq @gfellerph