Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove docs peer dependencies #2923

Closed
wants to merge 1 commit into from

Conversation

gfellerph
Copy link
Member

A weird workflow (changesets/changesets#1011) in changesets causes packages depending on others in the monorepo through peer dependencies to cause a major update on the upstream package. This is undesired in this scenario. Example:

design-system-components-angular has a patch update and is a peer dependency of the documentation. Because of that patch, the documentation has a major version bump for this release, even if there are no breaking changes.

A weird workflow (changesets/changesets#1011) in changesets causes packages depending on others in the monorepo through peer dependencies to cause a major update on the upstream package. This is undesired in this scenario. Example:

design-system-components-angular has a patch update and is a peer dependency of the documentation. Because of that patch, the documentation has a major version bump for this release, even if there are no breaking changes.
@gfellerph gfellerph requested a review from a team as a code owner April 10, 2024 14:29
@gfellerph gfellerph requested a review from imagoiq April 10, 2024 14:29
Copy link

changeset-bot bot commented Apr 10, 2024

⚠️ No Changeset found

Latest commit: 73e8b47

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@gfellerph
Copy link
Member Author

Superseded by #3009

@gfellerph gfellerph closed this Apr 26, 2024
@gfellerph gfellerph deleted the fix-peer-dependency-major-upgrad branch July 22, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants