Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add semantic layer token machinery #3349
feat: add semantic layer token machinery #3349
Changes from 10 commits
8800cad
1d4ac31
8c98caa
e84b51e
4798c4a
310e044
305ff06
684693c
21b2718
f2621eb
ef0b1c1
bb19961
cbafb2e
1d7ba3a
8b9c454
aba68d5
ffea852
783ab0f
b836913
97ffe7f
fcf60fc
a047516
0c86132
b2e6462
c3acc68
2afbe7f
f0ed82a
68fdfd1
11dac21
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't the breakpoints be tokenized too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we were talking about this. We'll update this once they are (also, there might be two more).
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.