feat(components): add a post-logo component #3354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
🦋 Changeset detectedLatest commit: dd6b79c The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
alizedebray
force-pushed
the
3206-component-logo
branch
from
9ae7ec1 to
7fb0696
Compare
alizedebray
changed the base branch from
main
to
3357-remove-card-control-scss-import
alizedebray
changed the base branch from
3357-remove-card-control-scss-import
to
main
gfellerph
approved these changes
Aug 9, 2024
| .logo { | ||
| display: inline-block; | ||
| height: 100%; | ||
| aspect-ratio: 1 / 1; |
There was a problem hiding this comment.
We had issues with Safari 14 which does not support aspect-ratio and displayed a logo that covered the whole screen. I can't test the preview on Safari 14 because Storybook apparently does not run on this browser. I'm not sure what the fallback would look like, but I'd like to ensure that this does not happen again with the new header (I know, Safari 14 is officially not supported anymore, but there was more than one support call from end-users for this issue).
|
gfellerph
pushed a commit
that referenced
this pull request
Aug 22, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @swisspost/[email protected] ### Minor Changes - Added the post-logo component, which enables displaying the Post's logo either as a clickable link or as a simple image. (by [@alizedebray](https://github.com/alizedebray) with [#3354](#3354)) ### Patch Changes - Fixed the `post-card-control` component to use the correct color scheme when placed on nested colored backgrounds. (by [@alizedebray](https://github.com/alizedebray) with [#3358](#3358)) - Updated dependencies: - @swisspost/[email protected] ## @swisspost/[email protected] ### Minor Changes - Added the post-logo component, which enables displaying the Post's logo either as a clickable link or as a simple image. (by [@alizedebray](https://github.com/alizedebray) with [#3354](#3354)) ### Patch Changes - Updated dependencies: - @swisspost/[email protected] ## @swisspost/[email protected] ### Minor Changes - Added icon number 2612. (by [@swisspost-bot](https://github.com/swisspost-bot) with [#3373](#3373)) ## @swisspost/[email protected] ### Minor Changes - Added four new entry files that enable working with Design Tokens: - post-external.(s)css: For portal and other external pages - post-internal.(s)css: For applications and other internal pages - post-tokens-external.(s)css: External tokens only - post-tokens-internal.(s)css: Internal tokens only (by [@gfellerph](https://github.com/gfellerph) with [#3349](#3349)) ### Patch Changes - Realigned the checkbox and the radio button with the label. (by [@davidritter-dotcom](https://github.com/davidritter-dotcom) with [#3366](#3366)) - Set the `max-width` constraint of the tag component to 100% for improved accessibility. Try to keep tag text as short as possible though. (by [@gfellerph](https://github.com/gfellerph) with [#3388](#3388)) ## @swisspost/[email protected] ### Patch Changes - Updated dependencies: - @swisspost/[email protected] ## @swisspost/[email protected] ### Patch Changes - Updated dependencies: - @swisspost/[email protected] ## @swisspost/[email protected] ### Patch Changes - Updated dependencies: - @swisspost/[email protected] ## @swisspost/[email protected] ## @swisspost/[email protected] ### Minor Changes - Added the post-logo component, which enables displaying the Post's logo either as a clickable link or as a simple image. (by [@alizedebray](https://github.com/alizedebray) with [#3354](#3354)) ### Patch Changes - Updated dependencies: - @swisspost/[email protected] ## @swisspost/[email protected] ### Minor Changes - Added the post-logo component, which enables displaying the Post's logo either as a clickable link or as a simple image. (by [@alizedebray](https://github.com/alizedebray) with [#3354](#3354)) ### Patch Changes - Fixed the font in the full page previews. (by [@alizedebray](https://github.com/alizedebray) with [#3378](#3378)) - Marked the card button and the carousel as deprecated (will be removed in a future version). (by [@schaertim](https://github.com/schaertim) with [#3380](#3380)) - Updated dependencies: - @swisspost/[email protected] - @swisspost/[email protected] - @swisspost/[email protected] - @swisspost/[email protected] - @swisspost/[email protected] ## @swisspost/[email protected] ### Patch Changes - Updated dependencies: - @swisspost/[email protected] - @swisspost/[email protected] ## @swisspost/[email protected] ### Patch Changes - Updated dependencies: - @swisspost/[email protected] - @swisspost/[email protected] - @swisspost/[email protected] ## @swisspost/[email protected] ### Patch Changes - Updated dependencies: - @swisspost/[email protected] ## @swisspost/[email protected] ### Patch Changes - Updated dependencies: - @swisspost/[email protected] ## @swisspost/[email protected] ### Patch Changes - Updated dependencies: - @swisspost/[email protected] - @swisspost/[email protected] - @swisspost/[email protected] ## @swisspost/[email protected] ### Patch Changes - Updated dependencies: - @swisspost/[email protected] --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.