Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix pnpm start command #3504

Merged
merged 2 commits into from
Sep 6, 2024
Merged

chore: fix pnpm start command #3504

merged 2 commits into from
Sep 6, 2024

Conversation

gfellerph
Copy link
Member

This change excludes @swisspost/design-system-styles from the vite optmizeDeps workflow for the documentation package. This seems to get rid of some of the "can't import dynamic dependency" issues.

Reloading after a style change is still pretty slow, but also a lot of unnecessry recompiles are happening. The potential for improvement is quite big here.

@gfellerph gfellerph requested a review from a team as a code owner September 6, 2024 11:53
Copy link

changeset-bot bot commented Sep 6, 2024

⚠️ No Changeset found

Latest commit: f1983f3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@swisspost-bot
Copy link
Contributor

swisspost-bot commented Sep 6, 2024

Related Previews

Copy link

sonarqubecloud bot commented Sep 6, 2024

@gfellerph gfellerph merged commit 2dd2915 into main Sep 6, 2024
11 of 12 checks passed
@gfellerph gfellerph deleted the fix-gulp-start branch September 6, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants