Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: foundations typography legend #3614

Merged
merged 18 commits into from
Oct 11, 2024

Conversation

bashirkarimi
Copy link
Contributor

No description provided.

@bashirkarimi bashirkarimi linked an issue Oct 2, 2024 that may be closed by this pull request
5 tasks
Copy link

changeset-bot bot commented Oct 2, 2024

🦋 Changeset detected

Latest commit: e5c3c87

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@swisspost/design-system-documentation Minor
@swisspost/design-system-styles Minor
@swisspost/design-system-components-angular-workspace Patch
@swisspost/design-system-components Minor
@swisspost/internet-header Patch
@swisspost/design-system-intranet-header-workspace Patch
@swisspost/design-system-nextjs-integration Patch
@swisspost/design-system-styles-primeng-workspace Patch
@swisspost/design-system-intranet-header Minor
@swisspost/design-system-styles-primeng Minor
@swisspost/design-system-components-react Minor
@swisspost/design-system-components-angular Minor
@swisspost/design-system-intranet-header-showcase Patch
@swisspost/design-system-tokens Minor
@swisspost/design-system-icons Minor
@swisspost/design-system-migrations Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@swisspost-bot
Copy link
Contributor

swisspost-bot commented Oct 2, 2024

Related Previews

@bashirkarimi bashirkarimi marked this pull request as ready for review October 2, 2024 12:56
@bashirkarimi bashirkarimi requested a review from a team as a code owner October 2, 2024 12:56
@gfellerph gfellerph self-requested a review October 3, 2024 16:17
.changeset/beige-jobs-do.md Outdated Show resolved Hide resolved
packages/styles/src/elements/reset.scss Outdated Show resolved Hide resolved
packages/styles/src/elements/legend.scss Outdated Show resolved Hide resolved
Copy link
Contributor

@oliverschuerch oliverschuerch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move the files to documentation/src/stories/foundations/ instead of documentation/src/stories/elements

.changeset/beige-jobs-do.md Outdated Show resolved Hide resolved
packages/styles/src/elements/fieldset-legend.scss Outdated Show resolved Hide resolved
@bashirkarimi
Copy link
Contributor Author

Please move the files to documentation/src/stories/foundations/ instead of documentation/src/stories/elements

It is moved.

@bashirkarimi bashirkarimi reopened this Oct 8, 2024
Copy link
Member

@gfellerph gfellerph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat!

.changeset/beige-jobs-do.md Outdated Show resolved Hide resolved
@bashirkarimi bashirkarimi merged commit c9be0cb into main Oct 11, 2024
9 checks passed
@bashirkarimi bashirkarimi deleted the 3415-foundations-typography-legend branch October 11, 2024 06:21
Copy link

gfellerph pushed a commit that referenced this pull request Oct 14, 2024
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.

⚠️⚠️⚠️⚠️⚠️⚠️

`main` is currently in **pre mode** so this branch has prereleases
rather than normal releases. If you want to exit prereleases, run
`changeset pre exit` on `main`.

⚠️⚠️⚠️⚠️⚠️⚠️

# Releases
## @swisspost/[email protected]

### Minor Changes

- Updated and tokenized styles for the legend element. (by
[@bashirkarimi](https://github.com/bashirkarimi) with
[#3614](#3614))

- Added styling support and documentation for the `<dialog>` element.
The dialog will replace the current modal and notification overlay
components coming from ng-bootstrap. (by
[@gfellerph](https://github.com/gfellerph) with
[#2772](#2772))

### Patch Changes

- Wrapped new token only entry files in a CSS layer called
'design-system'. The two files affected are 'post-tokens-external.scss'
and 'post-tokens-internal.scss' as well as their compiled CSS
counterparts. (by [@gfellerph](https://github.com/gfellerph) with
[#3720](#3720))

- Deprecated the ng-bootstrap components Modal and Notification overlay
in favor of the new Dialog component. The styles for these ng-bootstrap
components will be removed in a future major version. (by
[@gfellerph](https://github.com/gfellerph) with
[#2772](#2772))

- Fixed an issue with element styles that were not compiled to the
output as CSS. (by [@gfellerph](https://github.com/gfellerph) with
[#3709](#3709))

## @swisspost/[email protected]

### Patch Changes

-   Updated dependencies:
    -   @swisspost/[email protected]

## @swisspost/[email protected]

### Patch Changes

-   Updated dependencies:
    -   @swisspost/[email protected]

## @swisspost/[email protected]

### Patch Changes

- Initial release! (by [@gfellerph](https://github.com/gfellerph) with
[#3718](#3718))
-   Updated dependencies:
    -   @swisspost/[email protected]

## @swisspost/[email protected]

### Patch Changes

-   Updated dependencies:
    -   @swisspost/[email protected]

## @swisspost/[email protected]

### Patch Changes

-   Updated dependencies:
    -   @swisspost/[email protected]

## @swisspost/[email protected]

### Patch Changes

-   Updated dependencies:
    -   @swisspost/[email protected]

## @swisspost/[email protected]



## @swisspost/[email protected]



## @swisspost/[email protected]

### Minor Changes

- Updated and tokenized styles for the legend element. (by
[@bashirkarimi](https://github.com/bashirkarimi) with
[#3614](#3614))

- Added styling support and documentation for the `<dialog>` element.
The dialog will replace the current modal and notification overlay
components coming from ng-bootstrap. (by
[@gfellerph](https://github.com/gfellerph) with
[#2772](#2772))

### Patch Changes

-   Updated dependencies:
    -   @swisspost/[email protected]
    -   @swisspost/[email protected]
    -   @swisspost/[email protected]
    -   @swisspost/[email protected]
    -   @swisspost/[email protected]

## @swisspost/[email protected]

### Patch Changes

-   Updated dependencies:
    -   @swisspost/[email protected]
    -   @swisspost/[email protected]

## @swisspost/[email protected]

### Patch Changes

-   Updated dependencies:
    -   @swisspost/[email protected]

## @swisspost/[email protected]

### Patch Changes

-   Updated dependencies:
    -   @swisspost/[email protected]

## @swisspost/[email protected]

### Patch Changes

-   Updated dependencies:
    -   @swisspost/[email protected]
    -   @swisspost/[email protected]
    -   @swisspost/[email protected]

## @swisspost/[email protected]

### Patch Changes

-   Updated dependencies:
    -   @swisspost/[email protected]

## @swisspost/[email protected]

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[foundations]: Typography >Legend
4 participants