feat(components): create the post-breadcrumb-item #3659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
October 3, 2024 12:01
4 tasks
🦋 Changeset detectedLatest commit: 8b30c84 The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
alizedebray
requested changes
Oct 15, 2024
packages/components/src/components/post-breadcrumb-item/post-breadcrumb-item.scss
Outdated
Show resolved
Hide resolved
packages/components/src/components/post-breadcrumb-item/post-breadcrumb-item.scss
Outdated
Show resolved
Hide resolved
packages/components/src/components/post-breadcrumb-item/post-breadcrumb-item.tsx
Outdated
Show resolved
Hide resolved
packages/components/src/components/post-breadcrumb-item/post-breadcrumb-item.tsx
Outdated
Show resolved
Hide resolved
alizedebray
changed the title
added 8 commits
October 16, 2024 09:35
alizedebray
requested changes
Oct 29, 2024
packages/components/src/components/post-breadcrumb-item/post-breadcrumb-item.scss
Outdated
Show resolved
Hide resolved
packages/components/src/components/post-breadcrumb-item/post-breadcrumb-item.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Alizé Debray <[email protected]>
…validation and construction
…wisspost/design-system into 3277-component-breadcrumb-item
added 4 commits
November 4, 2024 13:00
alizedebray
approved these changes
Nov 8, 2024
| try { | ||
| this.validUrl = this.constructUrl(this.url); | ||
| } catch (error) { | ||
| console.error(error); |
There was a problem hiding this comment.
Can you just check if the error is logged twice and if so just remove this line?
|
gfellerph
pushed a commit
that referenced
this pull request
Nov 11, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.⚠️ ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ `main` is currently in **pre mode** so this branch has prereleases rather than normal releases. If you want to exit prereleases, run `changeset pre exit` on `main`.⚠️ ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ # Releases ## @swisspost/[email protected] ### Major Changes - Removed the `.breadcrumb-item` class, which previously handled styling for breadcrumb items. Introduced a new `post-breadcrumb-item` that should be used in place of the `.breadcrumb-item` class. (by [@alionazherdetska](https://github.com/alionazherdetska) with [#3659](#3659)) ### Minor Changes - Created the `post-list` and `post-list-item` components. (by [@myrta2302](https://github.com/myrta2302) with [#3812](#3812)) - Added close button web component. (by [@leagrdv](https://github.com/leagrdv) with [#3880](#3880)) ### Patch Changes - Fixed an issue with the post-collapsible throwing an invalid selector error. (by [@alizedebray](https://github.com/alizedebray) with [#3726](#3726)) - Updated dependencies: - @swisspost/[email protected] ## @swisspost/[email protected] ### Major Changes - Removed regular button size. Buttons that were previously using `btn-rg` will now fall back to the default `btn-md` size. (by [@leagrdv](https://github.com/leagrdv) with [#3849](#3849)) - Updated list group to v2 and added new options: list links, list documents and list switches. (by [@leagrdv](https://github.com/leagrdv) with [#3740](#3740)) - Removed the `btn-animated` class. It no longer has any effect and can be removed from existing buttons. (by [@leagrdv](https://github.com/leagrdv) with [#3849](#3849)) - Removed the `.breadcrumb-item` class, which previously handled styling for breadcrumb items. Introduced a new `post-breadcrumb-item` that should be used in place of the `.breadcrumb-item` class. (by [@alionazherdetska](https://github.com/alionazherdetska) with [#3659](#3659)) ### Minor Changes - Added Form Footer component. (by [@leagrdv](https://github.com/leagrdv) with [#3616](#3616)) - Created token-based styles for `<ul>` elements. (by [@oliverschuerch](https://github.com/oliverschuerch) with [#3859](#3859)) - Updated vertical-align utility (by [@myrta2302](https://github.com/myrta2302) with [#3805](#3805)) - Updated button component to v2. (by [@leagrdv](https://github.com/leagrdv) with [#3849](#3849)) - Added the skiplinks component to styles and documentation. (by [@leagrdv](https://github.com/leagrdv) with [#3875](#3875)) - Added close button web component. (by [@leagrdv](https://github.com/leagrdv) with [#3880](#3880)) - Internalized bootstraps floating utilities into the design system. (by [@myrta2302](https://github.com/myrta2302) with [#3752](#3752)) ## @swisspost/[email protected] ### Minor Changes - Added icon number 2632. (by [@gfellerph](https://github.com/gfellerph) with [#3952](#3952)) ## @swisspost/[email protected] ### Patch Changes - Updated dependencies: - @swisspost/[email protected] ## @swisspost/[email protected] ### Patch Changes - Updated dependencies: - @swisspost/[email protected] ## @swisspost/[email protected] ### Patch Changes - Updated dependencies: - @swisspost/[email protected] ## @swisspost/[email protected] ### Patch Changes - Updated dependencies: - @swisspost/[email protected] ## @swisspost/[email protected] ## @swisspost/[email protected] ## @swisspost/[email protected] ### Minor Changes - Updated list group to v2 and added new options: list links, list documents and list switches. (by [@leagrdv](https://github.com/leagrdv) with [#3740](#3740)) - Created the `post-list` and `post-list-item` components. (by [@myrta2302](https://github.com/myrta2302) with [#3812](#3812)) - Updated the Accessibility documentation section with Form Labels guidelines. (by [@myrta2302](https://github.com/myrta2302) with [#3835](#3835)) - Added Form Footer component. (by [@leagrdv](https://github.com/leagrdv) with [#3616](#3616)) - Updated vertical-align utility (by [@myrta2302](https://github.com/myrta2302) with [#3805](#3805)) - Added the skiplinks component to styles and documentation. (by [@leagrdv](https://github.com/leagrdv) with [#3875](#3875)) - Added close button web component. (by [@leagrdv](https://github.com/leagrdv) with [#3880](#3880)) - Internalized bootstraps floating utilities into the design system. (by [@myrta2302](https://github.com/myrta2302) with [#3752](#3752)) ### Patch Changes - Updated basic `<ul>` element docs and moved them from `Utilities/Lists` to `Foundation/Typography/Lists`. (by [@oliverschuerch](https://github.com/oliverschuerch) with [#3859](#3859)) - Updated dependencies: - @swisspost/[email protected] - @swisspost/[email protected] - @swisspost/[email protected] - @swisspost/[email protected] - @swisspost/[email protected] ## @swisspost/[email protected] ### Patch Changes - Updated dependencies: - @swisspost/[email protected] - @swisspost/[email protected] ## @swisspost/[email protected] ### Patch Changes - Updated dependencies: - @swisspost/[email protected] ## @swisspost/[email protected] ### Patch Changes - Updated dependencies: - @swisspost/[email protected] ## @swisspost/[email protected] ### Patch Changes - Updated dependencies: - @swisspost/[email protected] ## @swisspost/[email protected] ### Patch Changes - Updated dependencies: - @swisspost/[email protected] - @swisspost/[email protected] - @swisspost/[email protected] ## @swisspost/[email protected] ### Patch Changes - Updated dependencies: - @swisspost/[email protected] --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.