Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(component): breadcrumb #4065
feat(component): breadcrumb #4065
Changes from 64 commits
83af2d8
d7a492f
e86d577
4987f1c
6841892
d22d45b
90a9312
5edc4f0
6b5adf1
39d042e
4950ed5
d3addef
49b91fc
183dff1
eae5391
b01b65d
8a17215
fcd616c
ad09b13
f915a40
0d902bb
a9a0877
2fbdd93
9ce3b8f
6927c4c
1d71fa4
d02acda
d1401b9
1602a4c
6a9aecd
ac93738
13ffcbb
9936f57
271b84f
c011aba
e1ca0ea
ccbfd49
6cfe335
dcfc23e
9e7911a
61d23fc
59f0634
1f17171
94b0080
8c25cdb
46f9c8b
9cf9262
141d839
4f08283
1170ba0
b622c11
63d2ff8
766c70d
9438314
f3c091c
2d88656
02caaaf
a0186cd
57bccd6
1a814c3
51e7265
d5a8c7e
0ff21c9
1317e36
a373105
9188fb1
e227e8e
ad58fd9
071322c
39d7745
9d1db5d
8333ae3
c167a2b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Breadcrumb items in the dropdown should not have a visible arrow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nesting all of these styles creates unnecessary specific selectors in CSS. Every level of nesting will add specificity to a selector:
.breadcrumbs-nav .breadcrumbs-list li a etc.
. Because we're in a shadow root, we don't need to be this specific.Use nesting only if you need to make the selector more specific like
ul > li
needs theul
part to work.