Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(component): fix tab isolation in nested post-tabs component (cherry pick #4211 to v8) #4214

Open
wants to merge 3 commits into
base: release/v8
Choose a base branch
from
Open

fix(component): fix tab isolation in nested post-tabs component (cherry pick #4211 to v8) #4214

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1b6716c
fix(component): fix tab isolation in nested `post-tabs` component (#4…
alionazherdetska Dec 12, 2024
a12e712
Update packages/components/src/components/post-tabs/post-tabs.tsx
alionazherdetska Dec 13, 2024
04d1ffb
fix(post_tabs): fixed selector
alionazherdetska Dec 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/gorgeous-glasses-end.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@swisspost/design-system-components': patch
---

Fix tab isolation in nested `post-tabs` components by scoping tab queries and interactions to the current instance.
10 changes: 5 additions & 5 deletions packages/components/src/components/post-tabs/post-tabs.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,9 @@ export class PostTabs {
private hiding: Animation;
private isLoaded = false;

private get tabs(): NodeListOf<HTMLPostTabHeaderElement> {
return this.host.querySelectorAll('post-tab-header');
}
private get tabs(): HTMLPostTabHeaderElement[] {
return Array.from(this.host.querySelectorAll(':scope > post-tab-header'));
}

@Element() host: HTMLPostTabsElement;

Expand All @@ -45,7 +45,7 @@ export class PostTabs {
this.moveMisplacedTabs();
this.enableTabs();

const initiallyActivePanel = this.activePanel || this.tabs.item(0).panel;
const initiallyActivePanel = this.activePanel || this.tabs[0]?.panel;
void this.show(initiallyActivePanel);

this.isLoaded = true;
Expand Down Expand Up @@ -128,7 +128,7 @@ export class PostTabs {

// if the currently active tab was removed from the DOM then select the first one
if (this.activeTab && !this.activeTab.isConnected) {
void this.show(this.tabs.item(0).panel);
void this.show(this.tabs[0]?.panel);
}
}

Expand Down
Loading