fix(components): use base tag href if defined for post-icon #4217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ac411e9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 17 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Related Previews |
|
alizedebray
requested changes
Dec 13, 2024
| @@ -131,7 +131,8 @@ export class PostIcon { | |||
| .querySelector('meta[name="design-system-settings"][data-post-icon-base]') | |||
| ?.getAttribute('data-post-icon-base') ?? null; | |||
|
|
|||
| const fileBase = `${this.base ?? metaBase ?? CDN_URL}/`.replace(/\/\/$/, '/'); | |||
| const baseHref = document.getElementsByTagName('base')[0]?.href; | |||
| const fileBase = `${this.base ?? metaBase ?? baseHref ?? CDN_URL}/`.replace(/\/\/$/, '/'); | |||
There was a problem hiding this comment.
If you set a base tag, you expect the base URL to be use for all relative URLs in the code. Therefore the baseHref should not replace the icon base path but it should be added to the metaBase or to this.base if they are relative.
oliverschuerch
force-pushed
the
release/v7
branch
from
c56c93d to
52277d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.