Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(components): update style of language switch and fix keyboard nav #4260

Merged
merged 7 commits into from
Dec 20, 2024

Conversation

leagrdv
Copy link
Contributor

@leagrdv leagrdv commented Dec 13, 2024

No description provided.

@leagrdv leagrdv requested review from a team as code owners December 13, 2024 14:54
@leagrdv leagrdv requested a review from alizedebray December 13, 2024 14:54
@leagrdv leagrdv linked an issue Dec 13, 2024 that may be closed by this pull request
5 tasks
Copy link

changeset-bot bot commented Dec 13, 2024

🦋 Changeset detected

Latest commit: aab2fa6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@swisspost/design-system-documentation Major
@swisspost/design-system-components Major
@swisspost/design-system-components-angular-workspace Patch
@swisspost/design-system-components-react Major
@swisspost/design-system-components-angular Major
@swisspost/design-system-nextjs-integration Patch
@swisspost/design-system-styles Major
@swisspost/design-system-tokens Major
@swisspost/design-system-intranet-header Major
@swisspost/design-system-icons Major
@swisspost/design-system-migrations Major
@swisspost/design-system-styles-primeng Major
@swisspost/internet-header Patch
@swisspost/design-system-intranet-header-workspace Patch
@swisspost/design-system-styles-primeng-workspace Patch
@swisspost/design-system-intranet-header-showcase Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@swisspost-bot
Copy link
Contributor

swisspost-bot commented Dec 13, 2024

Related Previews

@gfellerph gfellerph linked an issue Dec 16, 2024 that may be closed by this pull request
Copy link
Contributor

@alizedebray alizedebray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The focus ring is still blue on desktop and the gap between the language options is no correct on mobile (should be 8px).

alizedebray and others added 4 commits December 18, 2024 17:09
The changes to the post-menu are part of the PR #4337 that should be
merge before this one.

:information_source: **Only the commit
b899725
needs to be reviewed in this PR.**

---------

Co-authored-by: Lea <[email protected]>
@leagrdv leagrdv requested a review from alizedebray December 20, 2024 10:38
@leagrdv leagrdv merged commit 07824c4 into main Dec 20, 2024
10 checks passed
@leagrdv leagrdv deleted the 4248-language-switch-improvement branch December 20, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug]: Language switch keyboard interactions Language switch improvement
3 participants