Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(components): header hcm #4262

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

chore(components): header hcm #4262

wants to merge 9 commits into from

Conversation

myrta2302
Copy link
Contributor

No description provided.

@myrta2302 myrta2302 requested a review from a team as a code owner December 13, 2024 15:14
@myrta2302 myrta2302 linked an issue Dec 13, 2024 that may be closed by this pull request
4 tasks
Copy link

changeset-bot bot commented Dec 13, 2024

🦋 Changeset detected

Latest commit: 7f49a03

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@swisspost/design-system-components Patch
@swisspost/design-system-styles Patch
@swisspost/design-system-components-angular-workspace Patch
@swisspost/design-system-components-react Patch
@swisspost/design-system-documentation Patch
@swisspost/design-system-components-angular Patch
@swisspost/internet-header Patch
@swisspost/design-system-intranet-header-workspace Patch
@swisspost/design-system-nextjs-integration Patch
@swisspost/design-system-styles-primeng-workspace Patch
@swisspost/design-system-intranet-header Patch
@swisspost/design-system-styles-primeng Patch
@swisspost/design-system-intranet-header-showcase Patch
@swisspost/design-system-tokens Patch
@swisspost/design-system-icons Patch
@swisspost/design-system-migrations Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@swisspost-bot
Copy link
Contributor

swisspost-bot commented Dec 13, 2024

Related Previews

alizedebray
alizedebray previously approved these changes Dec 17, 2024
Copy link
Contributor

@alizedebray alizedebray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add a border to separate the mobile menu from the page bellow?
image

@alizedebray alizedebray dismissed their stale review December 17, 2024 12:13

Some things should be fixed.

Copy link
Contributor

@alizedebray alizedebray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The preview does not seem to be up-to-date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Header HCM
3 participants