Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(styles): fix focus indicator visibility for links in accordion items inside the footer on mobile #4306

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fix(styles): fix focus indicator visibility for links in accordion items inside the footer on mobile #4306

wants to merge 5 commits into from

Conversation

alionazherdetska
Copy link
Contributor

…ems on mobile

@alionazherdetska alionazherdetska requested a review from a team as a code owner December 16, 2024 13:05
@alionazherdetska alionazherdetska linked an issue Dec 16, 2024 that may be closed by this pull request
[bug]: Incomplete focus Indicator for Footer links on mobile #4281
Open
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 16, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 23e17a5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@alionazherdetska alionazherdetska changed the title fix(styles): fix focus indicator visibility for links in accordion it… fix(styles): fix focus indicator visibility for links in accordion items on mobile Dec 16, 2024
@alionazherdetska alionazherdetska changed the title fix(styles): fix focus indicator visibility for links in accordion items on mobile fix(styles): fix focus indicator visibility for links in accordion items inside the footer on mobile Dec 16, 2024
@swisspost-bot
Copy link
Contributor

swisspost-bot commented Dec 16, 2024 •
edited
Loading

Related Previews

alizedebray
alizedebray requested changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@alizedebray alizedebray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this issue happens with the footer, it could also happen for anyone using the post-collapsible. I would rather fix the post-collapsible overflow than adding specific code for the footer. The hidden overflow is actually only necessary when the collapsible is closed and during the transition but it can be removed when it is open.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

alizedebray
alizedebray requested changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@alizedebray alizedebray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rather update the expand animation so that we do not have the same issue with another component in the future?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alizedebray alizedebray alizedebray requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug]: Incomplete focus Indicator for Footer links on mobile
3 participants
@alionazherdetska @swisspost-bot @alizedebray