improved error handling

README.md

@@ -244,7 +244,7 @@ ModuleConfiguration config = with()
 JsonObject json = config.asJsonObject();
 ```
 
-Properties not overridden will not be changed. Thus remaining default.x-lock-mode
+Properties not overridden will not be changed. Thus remaining default.
 
 To use default values only, the _ModuleConfiguration_ constructor without parameters can be used:
 

src/main/java/org/swisspush/reststorage/s3/FileReadStream.java

@@ -165,14 +165,15 @@ private void doRead(Buffer writeBuff, int offset, ByteBuffer buff, long position
             try {
                 Integer bytesRead = ch.read(buff);
                 future.complete(bytesRead);
-            } catch (Exception e) {
-                log.error("", e);
+            } catch (IOException e) {
+                log.error("Failed to read data from buffer.", e);
                 future.fail(e);
             }
 
         }, res -> {
 
             if (res.failed()) {
+                log.error("Failed to read data from buffer.", res.cause());
                 context.runOnContext((v) -> handler.handle(Future.failedFuture(res.cause())));
             } else {
                 // Do the completed check
@@ -232,7 +233,6 @@ private void handleException(Throwable t) {
             exceptionHandler.handle(t);
         } else {
             log.error("Unhandled exception", t);
-
         }
     }
 

src/main/java/org/swisspush/reststorage/s3/FileWriteStream.java

@@ -6,11 +6,15 @@
 import io.vertx.core.Promise;
 import io.vertx.core.buffer.Buffer;
 import io.vertx.core.streams.WriteStream;
+import org.slf4j.Logger;
 
 import java.io.OutputStream;
 import java.io.IOException;
 
+import static org.slf4j.LoggerFactory.getLogger;
+
 public class FileWriteStream implements WriteStream<Buffer> {
+    private static final Logger log = getLogger(FileWriteStream.class);
     private final OutputStream outputStream;
     private Handler<Throwable> exceptionHandler;
     private Handler<Void> drainHandler;
@@ -37,6 +41,7 @@ public void write(Buffer buffer, Handler<AsyncResult<Void>> handler) {
             if (exceptionHandler != null) {
                 exceptionHandler.handle(e);
             }
+            log.error("Error writing to stream", e);
             handler.handle(Future.failedFuture(e));
         }
     }
@@ -52,6 +57,7 @@ public Future<Void> write(Buffer buffer) {
             if (exceptionHandler != null) {
                 exceptionHandler.handle(e);
             }
+            log.error("Error writing to stream", e);
             promise.fail(e);
         }
         return promise.future();
@@ -67,6 +73,7 @@ public void end(Handler<AsyncResult<Void>> handler) {
             if (exceptionHandler != null) {
                 exceptionHandler.handle(e);
             }
+            log.error("Error when try to end stream", e);
             handler.handle(Future.failedFuture(e));
         }
     }
@@ -82,6 +89,7 @@ public Future<Void> end() {
             if (exceptionHandler != null) {
                 exceptionHandler.handle(e);
             }
+            log.error("Error when try to end stream", e);
             promise.fail(e);
         }
         return promise.future();

src/main/java/org/swisspush/reststorage/s3/S3FileSystemStorage.java

@@ -17,6 +17,7 @@
 import java.io.IOException;
 import java.io.InputStream;
 import java.io.OutputStream;
+import java.io.UncheckedIOException;
 import java.net.URI;
 import java.nio.file.DirectoryNotEmptyException;
 import java.nio.file.DirectoryStream;
@@ -84,7 +85,7 @@ public S3FileSystemStorage(Vertx vertx, RestStorageExceptionFactory exceptionFac
         try (var pathStream = Files.walk(root)) {
             pathStream.forEach(System.out::println);
         } catch (IOException e) {
-            throw new RuntimeException(e);
+            throw new UncheckedIOException(e);
         }
 
         this.fileSystemDirLister = new S3FileSystemDirLister(vertx, root.toString());