pytest-lsp: Forward a server's stderr output
#147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobb10001
reviewed
Feb 6, 2024
lib/pytest-lsp/pytest_lsp/client.py
Outdated
| await super().start_io(cmd, *args, **kwargs) | ||
|
|
||
| # Forward the server's stderr to this process' stderr | ||
| if self._server and self._server: |
There was a problem hiding this comment.
Checking self._server twice. Is this a typo?
Suggested change
| if self._server and self._server: | |
| if self._server: |
There was a problem hiding this comment.
Ah, good spot that should be self._server and self._server.stderr:
alcarney
force-pushed
the
stderr
branch
2 times, most recently
from
937515f
to
9cd5089
Compare
This should be enough in most cases to get pytest to report the server's log output on failure. There may be issues if there are multiple servers running concurrently/within the same session but we will cross that bridge if/when it becomes an issue.
alcarney
commented
Feb 7, 2024
| items = [] | ||
|
|
||
| for i in range(10): | ||
| print(f"Suggesting item {i}", file=sys.stderr, flush=True) |
There was a problem hiding this comment.
TIL stderr was only changed to be line-buffered by default in Python 3.9, so to work in 3.8 we need to set flush=True here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be enough in most cases to get pytest to report the server's log output on failure.
There may be issues if there are multiple servers running concurrently/within the same session but we will cross that bridge if/when it becomes an issue.
Closes #143