-
Notifications
You must be signed in to change notification settings - Fork 496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: extend the available styles for mode
by separating mode
from the separator
styles
#1953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 26, 2024
Closed
sxyazi
added a commit
that referenced
this pull request
Nov 26, 2024
…om the `separator` styles (#1953)
sxyazi
added a commit
that referenced
this pull request
Nov 26, 2024
…om the `separator` styles (#1953)
sxyazi
added a commit
to yazi-rs/flavors
that referenced
this pull request
Nov 26, 2024
I noticed you changed |
boydaihungst
added a commit
to boydaihungst/relative-motions.yazi
that referenced
this pull request
Nov 26, 2024
User config file is always yazi/yazi-config/preset/theme-base.toml Lines 1 to 3 in 5e48df5
|
@sxyazi Thank you, for your effort to implement this! I appreciate it. 👍 ❤️ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An implementation of the feature request: #732, #1228
Closes #732, #1228
Previously, only a single mode style was supported, which meant the same mode style was used for both the highlight and secondary colors, and the separator style was applied to the secondary color.
This led to the inability to set different styles for the primary color of the mode, and users couldn't control the mode style independently because it depended on the separator style.
This PR separates the mode from the separator style, making it its own distinct style. Users will now be able to set different main and alternate styles for each of the 3 modes individually.
mode_normal
,mode_select
,mode_unset
, andseparator_style
have been separated into a new, independent[mode]
section:normal_main
- Main style for the normal modenormal_alt
- Alternate style for the normal modeselect_main
- Main style for the select modeselect_alt
- Alternate style for the select modeunset_main
- Main style for the unset modeunset_alt
- Alternate style for the unset modepermissions_t
,permissions_r
,permissions_w
,permissions_x
, andpermissions_s
have been renamed toperm_type
,perm_read
,perm_write
,perm_exec
, andperm_sep
to improve readability and align with the naming conventions in #1761.