-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support assets
installation for the ya pack
subcommand
#1973
Conversation
Is there an option to use a different folder name instead of |
@boydaihungst Specifying the assets directory name when adding a plugin means you'll still need to specify it when uninstalling, otherwise Yazi won't know if the user has used a custom assets name, which can mess with automation a bit. Also, this doesn't seem to affect existing plugins - it's just that directories that weren't copied before will now be copied during installation. On another note, it's not recommended to put preview images alongside the code because they're large binaries, which can slow down the cloning process when installing plugins. The recommended approach is to drag the image into the markdown file to upload it, and GitHub will automatically create a permanent link for it, like this https://github.com/yazi-rs/plugins/blob/a53d5440481f0f9a2160ded47d343bd22ffbc1fb/chmod.yazi/README.md?plain=1#L5 (not an image but a video though). |
@sxyazi Alright. To makes it less complicated, I will rename my plugins's assets folder to something else. 👍 |
Thanks for the PR @zooeywm! I tested it and found that there seems to be an issue with file status synchronization, where files in the (local plugin's) |
Hi @sxyazi , I've just tried to solve the synchronization between config files status and local state files in commit 5ef2e81. By write rev to the TRACK file, check if the recorded rev is the same as new rev, if not, the Thanks for review and hope that works! |
ya
for miscellaneous files in folder assets
assets
installation for the ya pack
subcommand
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
feature for #1947 , haven tested based on my sudo.yazi fork