Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added new options to the `find' command for smart-case/case-insensitive finds #240

Merged
merged 5 commits into from
Oct 4, 2023
Merged

feat: added new options to the `find' command for smart-case/case-insensitive finds #240

merged 5 commits into from
Oct 4, 2023

Conversation

ndtoan96
Copy link
Contributor

@ndtoan96 ndtoan96 commented Oct 2, 2023 •
edited by sxyazi
Loading

Close #239

@sxyazi
Copy link
Owner

sxyazi commented Oct 3, 2023 •
edited
Loading

Well done! I'd like to hide it behind find --smart and change the default / and ? to it.

This will be advantageous for us to later add something like find --insensitive without breaking this behavior.

@sxyazi sxyazi changed the title Dynamic case sensitivity in find feat: smart-case in find Oct 3, 2023
@ndtoan96
Copy link
Contributor Author

ndtoan96 commented Oct 3, 2023

I added --smart-case and --ignore-case flags and changed keymap to use --smart-case.

@sxyazi sxyazi changed the title feat: smart-case in find feat: added new options to the `find' command for smart-case/case-insensitive finding Oct 4, 2023
@sxyazi
Copy link
Owner

sxyazi commented Oct 4, 2023

Thank you!

@sxyazi sxyazi merged commit 6da04c7 into sxyazi:main Oct 4, 2023
@sxyazi sxyazi changed the title feat: added new options to the `find' command for smart-case/case-insensitive finding feat: added new options to the `find' command for smart-case/case-insensitive finds Oct 4, 2023
@branchvincent branchvincent mentioned this pull request Oct 21, 2023
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Case insensitive find by default
2 participants
@ndtoan96 @sxyazi