Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: some colors not readable in light mode #264

Merged
merged 1 commit into from
Oct 13, 2023
Merged

fix: some colors not readable in light mode #264

merged 1 commit into from
Oct 13, 2023

Conversation

sxyazi
Copy link
Owner

@sxyazi sxyazi commented Oct 13, 2023

This PR is a follow-up to the #221

@magnetophon
Copy link

This fixes the issue for me, thanks!

@Brixy
Copy link
Contributor

Brixy commented Oct 13, 2023

Just if I’m not too late to the party:

Input windows do not completely cover preview images, see screenshot below. Yet, they do cover preview text completely.

screenshot

@magnetophon
Copy link

Input windows do not completely cover preview images, see screenshot below. Yet, they do cover preview text completely.

Same here when using WezTerm.
When I use Allacritty with ueberzug, the image covers the input window.

Maybe you should open a separate issue for this, as it's not really related to the colors issue.

@sxyazi
Copy link
Owner Author

sxyazi commented Oct 13, 2023

This is a known issue specific to the Kitty graphics protocol. Other protocols like iTerm2 and Sixel do not have this problem. I haven't found the time to fix it yet, perhaps it requires a more subtle eraser...

@sxyazi sxyazi merged commit 29e3136 into main Oct 13, 2023
3 checks passed
@sxyazi sxyazi deleted the pr-6351d2db branch October 13, 2023 10:49
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants