* layers/+lang/python/funcs.el: Rewrite spacemacs/pyenv-executable-find to support list #16819
Conversation
…nd to support list
| (setq i (1+ i)))) | ||
| executable)) | ||
| (executable-find command))) | ||
| (defun spacemacs/pyenv-executable-find (commands) |
There was a problem hiding this comment.
This function might be called in user configs. It would be nicer if it continued to accept a single command and treated it as a singleton list, for backwards compatibility.
There was a problem hiding this comment.
It would also avoid some unnecessary changes in this same file.
| (defun spacemacs/pyenv-executable-find (commands) | ||
| "Find executable taking pyenv shims into account. If the pyenv was | ||
| configured with \"system\" then the system exectutable will be included, | ||
| otherwise the system executable will be ignored." |
There was a problem hiding this comment.
Can you add documentation about how the function handles the commands argument? Specifically, it's important to note that it will return some path corresponding to some command (the first one that appears in the list?)
| (thing-at-point 'line)))) | ||
| (line (thing-at-point 'line))) | ||
| (let* ((exe (spacemacs/pyenv-executable-find '("trepan3k" "wdb" "ipdb3" "pudb3" "ipdb" "pudb" "python3"))) | ||
| (trace (pcase (file-name-nondirectory (or exe "")) |
There was a problem hiding this comment.
Nit: (and exe (file-name-nondirectory exe)) would be more elegant here, IMO (avoid unnecessarily calling the function file-name-nondirectory).
Rewrite the function
spacemacs/pyenv-executable-findfor better performance.Original function will invoke the '/bin/pyenv' twice to determine one command; then it has 24 invokes for the
/bin/pyenvtriggered by the functionspacemacs/python-toggle-breakpointon my local, with this patch the calls will reduce to 8.Please help review the changes, thanks