Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH Use class name instead of self #432

Merged
merged 1 commit into from
Jun 17, 2024
Merged

ENH Use class name instead of self #432

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Controllers/QueuedJobsAdmin.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ public function getEditForm($id = null, $fields = null)
{
$form = parent::getEditForm($id, $fields);

$filter = $this->jobQueue->getJobListFilter(null, self::config()->max_finished_jobs_age);
$filter = $this->jobQueue->getJobListFilter(null, static::config()->max_finished_jobs_age);

$list = QueuedJobDescriptor::get()->where($filter)->sort('Created', 'DESC');

Expand Down Expand Up @@ -199,7 +199,7 @@ public function createjob($data, Form $form)

// If the user has select the European date format as their setting then replace '/' with '-' in the
// date string so PHP treats the date as this format.
if (Security::getCurrentUser()->DateFormat == self::$date_format_european) {
if (Security::getCurrentUser()->DateFormat == QueuedJobsAdmin::$date_format_european) {
$time = str_replace('/', '-', $time ?? '');
}

Expand Down
2 changes: 1 addition & 1 deletion src/Services/QueuedJobService.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1321,7 +1321,7 @@ public function getJobListFilter($type = null, $includeUpUntil = 0)
*/
public function runQueue($queue)
{
if (!self::config()->get('disable_health_check')) {
if (!static::config()->get('disable_health_check')) {
$this->checkJobHealth($queue);
}
$this->checkdefaultJobs($queue);
Expand Down
Loading