Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gemspec bundler version removed #72

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

gemspec bundler version removed #72

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
62dd2fa
bundler version is removed from gemspec
Shekharrajak Jan 14, 2019
8e58cd1
disable rdoc/ri using --no-document
Shekharrajak Mar 14, 2019
f2baf3e
changes in appveyor in bundler version for Ruby version > 2.2
Shekharrajak Mar 14, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ script:
- if [[ "${RUBOCOP}" == "yes" ]]; then rubocop; fi

# Test ruby gem
- gem install gem-path --no-ri --no-rdoc
- gem install gem-path --no-document
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In latest version of Ruby (> 2.2) , we need to use --no-document, because --no-ri --no-rdoc is deprecated.

- cd $HOME/gems/symengine-0.1.0/
- bundle exec rspec

Expand Down
13 changes: 11 additions & 2 deletions appveyor.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,24 +5,33 @@ environment:
matrix:
- RUBY_VERSION: "21-x64"
PLATFORM: "x64"
USE_BUNDLER_2XX: "no"
- RUBY_VERSION: "21"
PLATFORM: "Win32"
USE_BUNDLER_2XX: "no"
- RUBY_VERSION: "22-x64"
PLATFORM: "x64"
USE_BUNDLER_2XX: "no"
- RUBY_VERSION: "22"
PLATFORM: "Win32"
USE_BUNDLER_2XX: "no"
- RUBY_VERSION: "200-x64"
PLATFORM: "x64"
USE_BUNDLER_2XX: "no"
- RUBY_VERSION: "200"
PLATFORM: "Win32"
USE_BUNDLER_2XX: "no"

install:

- SET PATH=C:\Ruby%RUBY_VERSION%\bin;%PATH%
- if [%PLATFORM%] == [x64] set DEVKIT=C:\Ruby23-x64\DevKit
- if [%PLATFORM%] == [Win32] set DEVKIT=C:\Ruby23\DevKit
- "%DEVKIT%\\devkitvars.bat"
- gem install bundler --no-rdoc --no-ri
- if [[ "${USE_BUNDLER_2XX}" == "yes" ]];
then gem install bundler --no-document;
else gem install bundler --no-document -v '~> 1.6';
fi
- bundler env
- bundle install

Expand All @@ -49,7 +58,7 @@ build_script:
- gem install symengine-0.1.0.gem --verbose

test_script:
- gem install gem-path --no-ri --no-rdoc
- gem install gem-path --no-document
- gem path symengine > temp.txt
- set /p RUBY_GEM_DIR=<temp.txt
# Test ruby gem
Expand Down
2 changes: 1 addition & 1 deletion symengine.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ Gem::Specification.new do |gem|
gem.extensions = ['ext/symengine/extconf.rb']
gem.license = 'MIT'

gem.add_development_dependency 'bundler', '~> 1.7'
gem.add_development_dependency 'bundler'
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Old version doesn't support the latest Ruby versions.

gem.add_development_dependency 'rspec', '~> 3.0'
gem.add_development_dependency 'rspec-its'
gem.add_development_dependency 'rdoc', '~> 4.0'
Expand Down