Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for symfony/webpack-encore #237

Merged
merged 1 commit into from
Sep 16, 2024
Merged

Add support for symfony/webpack-encore #237

merged 1 commit into from
Sep 16, 2024

Conversation

Kocal
Copy link
Contributor

@Kocal Kocal commented Sep 13, 2024 •
edited
Loading

Hi, I want to add Carsonbot to Symfony Webpack Encore, espcially for:

  • handle staled issues (we have ~220 issues!)
  • auto-label pull-request by their type (feature, bug, deprecation, ...)

I don't think there is more to do in the PR. I believe the next steps (that I can't do) are:

  1. setup SYMFONY_WEBPACK_ENCORE_SECRET env var in infra
  2. Maybe setup GitHub webbooks?

Thanks!

EDIT: failing checks fixed in #238

@Kocal Kocal mentioned this pull request Sep 13, 2024
Merged
@Kocal Kocal force-pushed the webpack-encore-changes branch from 8b5cdb6 to eb5d799 Compare September 13, 2024 19:41
@fabpot
Copy link
Contributor

fabpot commented Sep 15, 2024

LGTM

xabbuh
xabbuh approved these changes Sep 15, 2024
View reviewed changes
Copy link
Member

@xabbuh xabbuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me as well

@OskarStark OskarStark changed the title Add support for symfony/webpack-encore Add support for symfony/webpack-encore Sep 16, 2024
@fabpot fabpot merged commit 8ad09c9 into symfony-tools:master Sep 16, 2024
4 checks passed
@Kocal Kocal deleted the webpack-encore-changes branch September 16, 2024 17:26
@Kocal Kocal mentioned this pull request Oct 1, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xabbuh xabbuh xabbuh approved these changes

@OskarStark OskarStark OskarStark approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Kocal @fabpot @OskarStark @xabbuh