Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement: Executed rector PHP 8.2 set #244

Merged
merged 2 commits into from
Sep 17, 2024
Merged

Enhancement: Executed rector PHP 8.2 set #244

merged 2 commits into from
Sep 17, 2024

Conversation

OskarStark
Copy link
Contributor

No description provided.

@OskarStark OskarStark requested a review from Nyholm September 16, 2024 16:37
Nyholm
Nyholm requested changes Sep 16, 2024
View reviewed changes
Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

I appreciate the annotation to attribute changes.
I think other changes is just noise. They dont help the project in any way.

Please just remove the rector.php file, then I am happy to merge.

rector.php Outdated Show resolved Hide resolved
@OskarStark OskarStark force-pushed the feature/rector branch 2 times, most recently from f480813 to bb02049 Compare September 17, 2024 06:33
@OskarStark
Copy link
Contributor Author

Ready to merge from my side

@OskarStark
Copy link
Contributor Author

Fixed psalm in my last commit @Nyholm

@OskarStark OskarStark requested a review from Nyholm September 17, 2024 08:16
Nyholm
Nyholm approved these changes Sep 17, 2024
View reviewed changes
Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@Nyholm Nyholm merged commit 11dcb58 into symfony-tools:master Sep 17, 2024
4 checks passed
@OskarStark OskarStark deleted the feature/rector branch September 17, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stof stof stof left review comments

@Nyholm Nyholm Nyholm approved these changes

Assignees
No one assigned
Labels
enhancement
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@OskarStark @stof @Nyholm