Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Execute migrations in CI #246

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

OskarStark
Copy link
Contributor

No description provided.

@OskarStark OskarStark self-assigned this Sep 17, 2024
@OskarStark OskarStark force-pushed the feature/use-migrations branch from 2eaa2ad to 8b8ab89 Compare September 17, 2024 08:13
@OskarStark
Copy link
Contributor Author

Rebased

@@ -31,7 +31,7 @@ jobs:
run: composer install --no-interaction --optimize-autoloader

- name: Setup database
run: bin/console doctrine:schema:create
run: bin/console doctrine:migrations:migrate --no-interaction
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why would I like this?

It just takes more time, right?

Is it because we want to make sure we have not forgotten to add migrations?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it because we want to make sure we have not forgotten to add migrations?

Yes

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okey. Fair.

Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@Nyholm Nyholm merged commit ced46ab into symfony-tools:master Sep 17, 2024
4 checks passed
@OskarStark OskarStark deleted the feature/use-migrations branch September 17, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants