Skip to content

Commit

Permalink
minor #185 Fix PHP 8.4 deprecations (javiereguiluz)
Browse files Browse the repository at this point in the history
This PR was merged into the main branch.

Discussion
----------

Fix PHP 8.4 deprecations

It fixes this:

```
SymfonyDocsBuilder\SymfonyHTMLFormat::__construct(): Implicitly marking parameter
$symfonyVersion as nullable is deprecated, the explicit nullable type must be used instead

SymfonyDocsBuilder\Renderers\SpanNodeRenderer::__construct(): Implicitly marking parameter
$symfonyVersion as nullable is deprecated, the explicit nullable type must be used instead
```

Commits
-------

d05cf42 Fix PHP 8.4 deprecations
  • Loading branch information
javiereguiluz committed Dec 12, 2024
2 parents 29ddf17 + d05cf42 commit a14f15a
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion src/Renderers/SpanNodeRenderer.php
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ public function __construct(
SpanNode $span,
BaseSpanNodeRenderer $decoratedSpanNodeRenderer,
?UrlChecker $urlChecker = null,
string $symfonyVersion = null
?string $symfonyVersion = null
)
{
parent::__construct($environment, $span);
Expand Down
2 changes: 1 addition & 1 deletion src/SymfonyHTMLFormat.php
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ final class SymfonyHTMLFormat implements Format
private $urlChecker;
private $symfonyVersion;

public function __construct(TemplateRenderer $templateRenderer, Format $HTMLFormat, ?UrlChecker $urlChecker = null, string $symfonyVersion = null)
public function __construct(TemplateRenderer $templateRenderer, Format $HTMLFormat, ?UrlChecker $urlChecker = null, ?string $symfonyVersion = null)
{
$this->templateRenderer = $templateRenderer;
$this->htmlFormat = $HTMLFormat;
Expand Down

0 comments on commit a14f15a

Please sign in to comment.