-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Console] Document the TreeHelper
#20786
Conversation
|
||
.. code-block:: text | ||
|
||
🔵 🟣 🟡 src |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love this example ❤️
🔵 🟢 🟢 🟠 🟡 DefaultController.php | ||
🔵 🟢 🟠 🟡 Kernel.php | ||
🔵 🟠 🟡 templates | ||
🔵 🔴 🟠 🟡 base.html.twig |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a versionadded directive below, like for other new features, thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The whole page is about the new tree helper, should i put the versionadded at the very start of the page ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think yes, and add it also in console/style.rst
after the new methods
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes please, so that a reader knows, since when this can be used
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would this work ? (last changes)
Link to the code PR is not working in the PR header |
TreeHelper
Fixed sorry |
cfb9dad
to
d9a48be
Compare
Thanks Simon for contributing this nice feature and for providing such detailed docs for it. While merging I did some tweaks (see a0758ac):
|
fix #20692