-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
[Mailer][Mime] Refactor S/MIME encryption handling in SMimeEncryptionListener
#20935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 7.3
Are you sure you want to change the base?
Conversation
I don't know much about this 🙏 but the previous example looked pretty convenient. Is it really a bad practice? If it's not, maybe we can show both alternatives? |
I thinks it's ok, but I don't really know others possible implementations |
Let's ask @Spomky. Could you please tell us if the example currently shown on Symfony Docs works and is valid? If it is, I think we should display both the current example and the new proposed ones (so folks don't overcomplicate things when not necessary). Thanks! |
Hi @alamirault and @javiereguiluz, Yes, the example looks good. The purpose of the |
; | ||
}; | ||
|
||
The ``repository`` option must be a service ID that implements | ||
:class:`Symfony\\Component\\Mailer\\EventListener\\SmimeCertificateRepositoryInterface`:: | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The purpose of the method SmimeCertificateRepositoryInterface::findCertificatePathFor
is to resolve the certificate file path for a given email address, as the S/MIME encrypter expects a valid local file path to the certificate.
Fix #20827
Having a
SmimeCertificateRepositoryInterface
implementation is a good thing I think.I don't really how to introduce it.