Skip to content

Commit

Permalink
minor #2451 [LiveComponent] Use container.build_hash instead of kerne…
Browse files Browse the repository at this point in the history
…l.secret in CacheWarmer (dkarlovi, smnandre)

This PR was merged into the 2.x branch.

Discussion
----------

[LiveComponent] Use container.build_hash instead of kernel.secret in CacheWarmer

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| Issues        | Fix #2419
| License       | MIT

<!--
Replace this notice by a description of your feature/bugfix.
This will help reviewers and should be a good start for the documentation.

Additionally (see https://symfony.com/releases):
 - Always add tests and ensure they pass.
 - For new features, provide some code snippets to help understand usage.
 - Features and deprecations must be submitted against branch main.
 - Changelog entry should follow https://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry
 - Never break backward compatibility (see https://symfony.com/bc).
-->

Commits
-------

257f9d2 Revert changelog update
fd1f745 Update CHANGELOG.md
2b31704 Update LiveComponentExtension.php
276a908 Update LiveComponentExtension.php
  • Loading branch information
smnandre committed Dec 24, 2024
2 parents 68821ae + 257f9d2 commit 41a7062
Showing 1 changed file with 2 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
use Symfony\Component\DependencyInjection\Definition;
use Symfony\Component\DependencyInjection\Extension\Extension;
use Symfony\Component\DependencyInjection\Extension\PrependExtensionInterface;
use Symfony\Component\DependencyInjection\Parameter;
use Symfony\Component\DependencyInjection\Reference;
use Symfony\UX\LiveComponent\Attribute\AsLiveComponent;
use Symfony\UX\LiveComponent\ComponentValidator;
Expand Down Expand Up @@ -258,7 +259,7 @@ function (ChildDefinition $definition, AsLiveComponent $attribute) {
->setArguments([
new Reference('twig.template_iterator'),
self::TEMPLATES_MAP_FILENAME,
'%kernel.secret%',
new Parameter('container.build_hash'),
])
->addTag('kernel.cache_warmer');
}
Expand Down

0 comments on commit 41a7062

Please sign in to comment.