Skip to content

Commit

Permalink
bug #1319 [StimulusBundle] Remove stimulus.asset_mapper.loader_javasc…
Browse files Browse the repository at this point in the history
…ript_compiler when no asset-mapper (Jibbarth)

This PR was merged into the 2.x branch.

Discussion
----------

[StimulusBundle] Remove stimulus.asset_mapper.loader_javascript_compiler when no asset-mapper

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| Issues        | Fix #1313
| License       | MIT

The service name was incorrect here.

All credits to `@smnandre` who found this gem

Commits
-------

1edc2e5 [StimulusBundle] Remove stimulus.asset_mapper.loader_javascript_compiler when no asset-mapper
  • Loading branch information
weaverryan committed Dec 1, 2023
2 parents dd7d24b + 1edc2e5 commit 4e0b7ad
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ public function process(ContainerBuilder $container)
if (!$container->hasDefinition('asset_mapper')) {
$container->removeDefinition('stimulus.ux_controllers_twig_runtime');
$container->removeDefinition('stimulus.asset_mapper.controllers_map_generator');
$container->removeDefinition('stimulus.asset_mapper.stimulus_loader_javascript_compiler');
$container->removeDefinition('stimulus.asset_mapper.loader_javascript_compiler');
}
}
}

0 comments on commit 4e0b7ad

Please sign in to comment.