[Icons] Add aliases when fetching multiples icons with Iconify

symfony · Dec 25, 2024 · 8ee5230 · 8ee5230
1 parent 07cbb0b
commit 8ee5230
Show file tree

Hide file tree

Showing 3 changed files with 48 additions and 2 deletions.
diff --git a/src/Icons/CHANGELOG.md b/src/Icons/CHANGELOG.md
@@ -1,5 +1,9 @@
 # CHANGELOG
 
+## 2.23.0
+
+-   Add support for aliases when fetching multiple icons with `Iconify` 
+
 ## 2.20.0
 
 -   Add `aliases` configuration option to define icon alternative names.

diff --git a/src/Icons/src/Iconify.php b/src/Icons/src/Iconify.php
@@ -126,7 +126,9 @@ public function fetchIcons(string $prefix, array $names): array
         $data = $response->toArray();
 
         $icons = [];
-        foreach ($data['icons'] as $iconName => $iconData) {
+        foreach ($names as $iconName) {
+            $iconData = $data['icons'][$data['aliases'][$iconName]['parent'] ?? $iconName];
+
             $height = $iconData['height'] ?? $data['height'] ??= $this->sets()[$prefix]['height'] ?? null;
             $width = $iconData['width'] ?? $data['width'] ??= $this->sets()[$prefix]['width'] ?? null;
 

diff --git a/src/Icons/tests/Unit/IconifyTest.php b/src/Icons/tests/Unit/IconifyTest.php
@@ -190,7 +190,47 @@ public function testFetchIcons(): void
         $icons = $iconify->fetchIcons('bi', ['heart', 'bar']);
 
         $this->assertCount(2, $icons);
-        $this->assertSame(['heart', 'bar'], array_keys($icons));
+        $this->assertSame(['bar', 'heart'], array_keys($icons));
+        $this->assertContainsOnlyInstancesOf(Icon::class, $icons);
+    }
+
+    public function testFetchIconsByAliases(): void
+    {
+        $iconify = new Iconify(
+            cache: new NullAdapter(),
+            endpoint: 'https://example.com',
+            http: new MockHttpClient([
+                new JsonMockResponse([
+                    'mdi' => [],
+                ]),
+                new JsonMockResponse([
+                    'aliases' => [
+                        'capsule' => [
+                            'parent' => 'pill',
+                        ],
+                        'sign' => [
+                            'parent' => 'draw',
+                        ],
+                    ],
+                    'icons' => [
+                        'pill' => [
+                            'body' => '<path d="M0 0h24v24H0z" fill="none"/>',
+                        ],
+                        'glasses' => [
+                            'body' => '<path d="M0 0h24v24H0z" fill="none"/>',
+                        ],
+                        'draw' => [
+                            'body' => '<path d="M0 0h24v24H0z" fill="none"/>',
+                        ],
+                    ],
+                ]),
+            ]),
+        );
+
+        $icons = $iconify->fetchIcons('mdi', ['capsule', 'sign', 'glasses']);
+
+        $this->assertCount(3, $icons);
+        $this->assertSame(['capsule', 'glasses', 'sign'], array_keys($icons));
         $this->assertContainsOnlyInstancesOf(Icon::class, $icons);
     }