Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LiveComponent] Use container.build_hash instead of kernel.secret in CacheWarmer #2451

Merged
merged 4 commits into from
Dec 24, 2024
Merged

[LiveComponent] Use container.build_hash instead of kernel.secret in CacheWarmer #2451

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
276a908
Update LiveComponentExtension.php
dkarlovi Dec 18, 2024
2b31704
Update LiveComponentExtension.php
dkarlovi Dec 18, 2024
fd1f745
Update CHANGELOG.md
dkarlovi Dec 20, 2024
257f9d2
Revert changelog update
smnandre Dec 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/LiveComponent/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
# CHANGELOG

- Use container.build_hash instead of kernel.secret in CacheWarmer
smnandre marked this conversation as resolved.
Show resolved Hide resolved

## 2.22.0

- Remove CSRF tokens - rely on same-origin/CORS instead
Expand Down
3 changes: 2 additions & 1 deletion src/LiveComponent/src/DependencyInjection/LiveComponentExtension.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
use Symfony\Component\DependencyInjection\Definition;
use Symfony\Component\DependencyInjection\Extension\Extension;
use Symfony\Component\DependencyInjection\Extension\PrependExtensionInterface;
use Symfony\Component\DependencyInjection\Parameter;
use Symfony\Component\DependencyInjection\Reference;
use Symfony\UX\LiveComponent\Attribute\AsLiveComponent;
use Symfony\UX\LiveComponent\ComponentValidator;
Expand Down Expand Up @@ -253,7 +254,7 @@ function (ChildDefinition $definition, AsLiveComponent $attribute) {
->setArguments([
new Reference('twig.template_iterator'),
self::TEMPLATES_MAP_FILENAME,
'%kernel.secret%',
new Parameter('container.build_hash'),
])
->addTag('kernel.cache_warmer');
}
Expand Down
Loading