Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Autocomplete] Deprecate ExtraLazyChoiceLoader in favor of LazyChoiceLoader #2458

Merged
merged 1 commit into from
Dec 24, 2024
Merged

[Autocomplete] Deprecate ExtraLazyChoiceLoader in favor of LazyChoiceLoader #2458

merged 1 commit into from
Dec 24, 2024
+8 −0

Conversation

norkunas
Copy link
Contributor

Q A
Bug fix? no
New feature? yes
Issues N/A
License MIT

@carsonbot carsonbot added Autocomplete Feature New Feature Status: Needs Review Needs to be reviewed labels Dec 20, 2024
@carsonbot carsonbot added Status: Reviewed Has been reviewed by a maintainer and removed Status: Needs Review Needs to be reviewed labels Dec 20, 2024
smnandre
smnandre reviewed Dec 21, 2024
View reviewed changes
Copy link
Member

@smnandre smnandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 great idea

src/Autocomplete/src/Form/ChoiceList/Loader/ExtraLazyChoiceLoader.php Outdated Show resolved Hide resolved
src/Autocomplete/src/Form/ChoiceList/Loader/ExtraLazyChoiceLoader.php Outdated Show resolved Hide resolved
smnandre
smnandre approved these changes Dec 22, 2024
View reviewed changes
Copy link
Member

@smnandre smnandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @norkunas!

@norkunas @smnandre
[Autocomplete] Deprecate ExtraLazyChoiceLoader in favor of `LazyCho…
0aadc00 
…iceLoader`

# Conflicts:
#	src/Autocomplete/CHANGELOG.md
@smnandre
Copy link
Member

Thank you Tomas.

@smnandre smnandre merged commit 58f8069 into symfony:2.x Dec 24, 2024
59 checks passed
@norkunas norkunas deleted the deprecate-loader branch January 2, 2025 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yceruto yceruto yceruto approved these changes

@smnandre smnandre smnandre approved these changes

Assignees
No one assigned
Labels
Autocomplete Feature New Feature Status: Reviewed Has been reviewed by a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@norkunas @smnandre @yceruto @carsonbot