Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[LiveComponent] Add support for downloading files from LiveActions (Experimental) #2483
base: 2.x
Are you sure you want to change the base?
[LiveComponent] Add support for downloading files from LiveActions (Experimental) #2483
Changes from 7 commits
bd6b8bd
61cee45
2f34d71
f24dea6
d7d6bb5
dd75be0
fe92cc7
f81dcff
4f6f869
36143e6
32cd824
456c0e2
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It depends... if you trigger the "click" and the file start downloading I think browser play the "pipe" role here.
But during my test I managed to crashed pretty violently Chrome and Safari multiple times.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we use the
$file
's mime type?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hesitated (keep dep light) and chose not to...
But in fact it's a good idea and Mime is a very small component.
So let's make it a requirement for LiveComponent ? Or only when using downloads / uploads ?
wdyt ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest to put it in
suggest
composer.json
section (I don't remember what is the rule in Symfony, cc @nicolas-grekas), and then runtime check ifsymfony/mime
exists (when using downloads/uploads)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty sure there is no suggest in Symfony composer packages..
We have other situations in UX where we do not require a package (i.e. in Autocomplete for Form ..)
My question was more: should we require it for everyone, or keep it as an "runtime" dependency ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
runtime dependency
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why aren't you deferring to BinaryFileResponse for this logic?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the reason for the header?
In the frontend, if not a standard/known content type, but has a content disposition (and an other requirements), trigger the download? This way we could say "to enable file downloads, return a response that has a content disposition"